Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set displacements without being asked #25804

Closed
lindsayad opened this issue Oct 21, 2023 · 2 comments · Fixed by #25805
Closed

Don't set displacements without being asked #25804

lindsayad opened this issue Oct 21, 2023 · 2 comments · Fixed by #25805
Assignees
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@lindsayad
Copy link
Member

Bug Description

I am looking at the input in #25778. If I apply the displacements in the mesh block, then I get errors from the heat conduction kernel, which is not block restricted, about how it's using coupled displacements which are on a subset of the mesh blocks. There is no displacements parameter in GlobalParams nor in the "offending" kernel block. Who is the offender then? Well it was me in fd20b95 . I probably did this for automatically coupling displacement variables into kernels for getting Jacobians right on displaced meshes ... but now we are seeing some bad side effects. @GiudGiud should keep this in mind when he is looking into #25800. Definitely don't want to blindly forward couplings from materials when it is possible a material (and variables it might use) may have a subset of the block restriction that the kernel does. (Think a thermal conductivity which is variable-dependent on one block and constant on another).

Steps to Reproduce

Turn the displacements on in the Mesh block in the input in #25778.

Impact

Users get errors for something they didn't even do.

@lindsayad lindsayad added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. labels Oct 21, 2023
@lindsayad lindsayad self-assigned this Oct 21, 2023
lindsayad added a commit to lindsayad/moose that referenced this issue Oct 21, 2023
lindsayad added a commit to lindsayad/moose that referenced this issue Oct 21, 2023
@GiudGiud
Copy link
Contributor

We need to be explicit about these things. i think the header of the simulation should say if the displaced mesh is in use.

And maybe have an info log with the objects that are not using it? Or a Debug option?

@lindsayad
Copy link
Member Author

We need to be explicit about these things. i think the header of the simulation should say if the displaced mesh is in use.

I think that's a good idea.

And maybe have an info log with the objects that are not using it? Or a Debug option?

Might as well print the undisplaced/displaced status of everything. For mechanics, except maybe for finite strain, I believe all residual objects are supposed to run on the undisplaced mesh so in such a case it would be more helpful to indicate the status of objects incorrectly running on the displaced mesh.

lynnmunday pushed a commit to zachmprince/moose that referenced this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants