MooseServerTest unit test are enforcing unrelated items

[GiudGiud]

Bug Description

See these two:

/data/civet2/build/moose/unit/src/MooseServerTest.C:596: Failure
      Expected: diagnostics_expect
      Which is: "\nline:18 column:0 - (BCs/all/boundary):\nline:18 column:0 -     the following side sets (ids) do not exist on the mesh: top (2), bottom (3)\nline:18 column:0 -     MOOSE distinguishes between \"node sets\" and \"side sets\" depending on whether\nline:18 column:0 -     you are using \"Nodal\" or \"Integrated\" BCs respectively. Node sets corresponding\nline:18 column:0 -     to your side sets are constructed for you by default.\nline:18 column:0 -     Try setting \"Mesh/construct_side_list_from_node_list=true\" if you see this error.\nline:18 column:0 -     Note: If you are running with adaptivity you should prefer using side sets.\n"
To be equal to: "\n" + diagnostics_actual.str()
      Which is: "\nline:18 column:0 - (BCs/all/boundary):\nline:18 column:0 -     the following side sets (ids) do not exist on the mesh: top (2), bottom (3)\nline:18 column:0 -     MOOSE distinguishes between \"node sets\" and \"side sets\" depending on whether \nline:18 column:0 -     you are using \"Nodal\" or \"Integrated\" BCs respectively. Node sets corresponding \nline:18 column:0 -     to your side sets are constructed for you by default.\nline:18 column:0 -     Try setting \"Mesh/construct_side_list_from_node_list=true\" if you see this error.\nline:18 column:0 -     Note: If you are running with adaptivity you should prefer using side sets.\n"
With diff:
@@ -2,6 +2,6 @@
 line:18 column:0 - (BCs/all/boundary):
 line:18 column:0 -     the following side sets (ids) do not exist on the mesh: top (2), bottom (3)
-line:18 column:0 -     MOOSE distinguishes between \"node sets\" and \"side sets\" depending on whether
-line:18 column:0 -     you are using \"Nodal\" or \"Integrated\" BCs respectively. Node sets corresponding
+line:18 column:0 -     MOOSE distinguishes between \"node sets\" and \"side sets\" depending on whether 
+line:18 column:0 -     you are using \"Nodal\" or \"Integrated\" BCs respectively. Node sets corresponding 
 line:18 column:0 -     to your side sets are constructed for you by default.
 line:18 column:0 -     Try setting \"Mesh/construct_side_list_from_node_list=true\" if you see this error.

[  FAILED  ] MooseServerTest.DocumentChangeAndDiagnostics (19 ms)

[ RUN      ] MooseServerTest.CompletionDocumentRootLevel
/data/civet2/build/moose/unit/src/MooseServerTest.C:936: Failure
      Expected: 46u
      Which is: 46
To be equal to: completions_array.size()
      Which is: 47
[  FAILED  ] MooseServerTest.CompletionDocumentRootLevel (0 ms)

The first one is likely because I formatted the test file by saving in VSCode
the second one is enforcing that the number of systems remains unchanged (after I already adapted a test that was enforcing the list of systems)

Enforcing formatting and enforcing things about the systems in MOOSE are not good ideas and unit tests ought to be more targetted than this.

Steps to Reproduce

Add a new system to MOOSE

Impact

Waste time dealing with unit tests failures

[brandonlangley]

@GiudGiud -

Thanks a lot for opening this issue and also for updating the test to no longer enforce the list of systems in 70297ec.

I also added a commit that updated the test to trim trailing whitespace and no longer enforce formatting in ce24f05.

With your commit being merged yesterday and my commit being merged in December, this issue can be closed now.

[GiudGiud]

I agree. Thanks for the whitespace fix.

Closing as resolved by 70297ec and ce24f05