Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding additional references to the grain growth documentation page in the phase field module #26890

Closed
tonkmr opened this issue Feb 26, 2024 · 2 comments · Fixed by #26907
Closed
Labels
C: Modules/Phase Field Tickets pertaining to the phase_field module T: task An enhancement to the software.

Comments

@tonkmr
Copy link
Contributor

tonkmr commented Feb 26, 2024

Reason

Professor LQ Chen reached out and correctly pointed out that currently we reference the Moelans [2008] paper for our grain growth model, but that that paper actually pulled the model from his earlier publications.

Design

He has asked that we reference two of his papers as well:
Chen, L.Q. And W. Yang, Computer-Simulation Of The Domain Dynamics Of A Quenched System With A Large Number Of Nonconserved Order Parameters - The Grain-Growth Kinetics. Physical Review B, 1994. 50(21): P. 15752-15756.
Chen, L.Q., A Novel Computer-Simulation Technique For Modeling Grain-Growth. Scripta Metallurgica Et Materialia, 1995. 32(1): P. 115-120.

Impact

This is a very minor change. It is only adding two references to a documentation page. There will be no impacts on anything else.

@tonkmr tonkmr added the T: task An enhancement to the software. label Feb 26, 2024
@tonkmr
Copy link
Contributor Author

tonkmr commented Feb 26, 2024

@dschwen @laagesen This is a minor change, but I am swamped right now. Could someone at INL make this change? Thanks!

@lindsayad lindsayad added the C: Modules/Phase Field Tickets pertaining to the phase_field module label Feb 26, 2024
@laagesen
Copy link
Contributor

Thanks for bringing this up @tonkmr, we will get it added to the doco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Modules/Phase Field Tickets pertaining to the phase_field module T: task An enhancement to the software.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants