Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use standard errors in THM #27064

Closed
joshuahansel opened this issue Mar 12, 2024 · 0 comments · Fixed by #27065
Closed

Use standard errors in THM #27064

joshuahansel opened this issue Mar 12, 2024 · 0 comments · Fixed by #27065
Assignees
@joshuahansel
Labels
C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@joshuahansel
Copy link
Contributor

Bug Description

THM uses its Logger class to queue up error and warning messages from components and other objects. Then at some point, the queued messages are printed instead of calling a standard error function like mooseError, which ultimately causes VSCode to crash.

Steps to Reproduce

Try using VSCode with a THM input file with a component error and observe that VSCode crashes.

Impact

This is a significant roadblock for those using THM and VSCode.

[Optional] Diagnostics

No response
@joshuahansel joshuahansel added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module labels Mar 12, 2024
@joshuahansel joshuahansel self-assigned this Mar 12, 2024
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 12, 2024
@joshuahansel
Renamed LogWarningComponent to LoggerTestComponent
209f9f5 
The class will be used for general testing of Logger, not
just warnings.

Also the test directory was moved to be consistent with the code
directory.

Refs idaholab#27064
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 12, 2024
@joshuahansel
Made methods in Logger to emit errors and warnings
738bec7 
Closes idaholab#27064
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 12, 2024
@joshuahansel
Removed some now unused methods in Logger
d253526 
Refs idaholab#27064
@joshuahansel joshuahansel mentioned this issue Mar 12, 2024
Merged
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 13, 2024
@joshuahansel
Made methods in Logger to emit errors and warnings
e1868c9 
Closes idaholab#27064
joshuahansel added a commit to joshuahansel/moose that referenced this issue Mar 13, 2024
@joshuahansel
Removed some now unused methods in Logger
ff5ccc3 
Refs idaholab#27064
jthano pushed a commit to jthano/moose that referenced this issue Mar 18, 2024
@joshuahansel @jthano
Renamed LogWarningComponent to LoggerTestComponent
9bd7aba 
The class will be used for general testing of Logger, not
just warnings.

Also the test directory was moved to be consistent with the code
directory.

Refs idaholab#27064
jthano pushed a commit to jthano/moose that referenced this issue Mar 18, 2024
@joshuahansel @jthano
Made methods in Logger to emit errors and warnings
774cb6a 
Closes idaholab#27064
jthano pushed a commit to jthano/moose that referenced this issue Mar 18, 2024
@joshuahansel @jthano
Removed some now unused methods in Logger
01857fb 
Refs idaholab#27064
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuahansel joshuahansel

Labels
C: Modules/Thermal Hydraulics Tickets pertaining to the thermal_hydraulics module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use mooseError and mooseWarning in THM's Logger joshuahansel/moose
1 participant
@joshuahansel