Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make EigenProblem respect the "solve" parameter in the same way as FEProblem #27084

Closed
jthano opened this issue Mar 14, 2024 · 0 comments · Fixed by #27085
Closed

Make EigenProblem respect the "solve" parameter in the same way as FEProblem #27084

jthano opened this issue Mar 14, 2024 · 0 comments · Fixed by #27085
Assignees
@jthano
Labels
C: Framework T: task An enhancement to the software.

Comments

@jthano
Copy link
Contributor

jthano commented Mar 14, 2024

Motivation

If the solve parameter is set to false, when using FEProblem, FEProblemBase::nlConverged will return true. But EigenProblem::nlConverged has a different behavior and does not consider that the solve=false

Design

Make EigenProblem::nlConverged consistent with FEProblemBase::nlConverged to get the expected behavior when solve=false

Impact

No impact to most users. Only something likely noticed by people writing custom executioners
@jthano jthano added the T: task An enhancement to the software. label Mar 14, 2024
@jthano jthano mentioned this issue Mar 14, 2024
Merged
jthano added a commit to jthano/moose that referenced this issue Mar 14, 2024
@jthano
make EigenProblem consistent with FEProblem when solve=false idaholab…
40f6591 
…#27084
jthano added a commit to jthano/moose that referenced this issue Mar 14, 2024
@jthano
adding test idaholab#27084
948e35e
jthano added a commit to jthano/moose that referenced this issue Mar 14, 2024
@jthano
adding test idaholab#27084
17bd5c6
jthano added a commit to jthano/moose that referenced this issue Mar 14, 2024
@jthano
adding test idaholab#27084
4287715
jthano added a commit to jthano/moose that referenced this issue Mar 14, 2024
@jthano
adding test idaholab#27084
78a9d38
jthano added a commit to jthano/moose that referenced this issue Mar 14, 2024
@jthano
adding test idaholab#27084
fa51b95
jthano added a commit to jthano/moose that referenced this issue Mar 18, 2024
@jthano
Fix test idaholab#27084
0c068df
@jthano jthano mentioned this issue Mar 18, 2024
Merged
jthano added a commit to jthano/moose that referenced this issue Mar 18, 2024
@jthano
make EigenProblem consistent with FEProblem when solve=false idaholab…
268f8aa 
…#27084
jthano added a commit to jthano/moose that referenced this issue Mar 18, 2024
@jthano
adding test idaholab#27084
a3f5e30
jthano added a commit to jthano/moose that referenced this issue Mar 18, 2024
@jthano
Fix test idaholab#27084
982072b
jthano added a commit to jthano/moose that referenced this issue Mar 18, 2024
@jthano
Fix test idaholab#27084
8b1cc4c
ke7kto pushed a commit to ke7kto/moose that referenced this issue May 22, 2024
@jthano @ke7kto
Fix test idaholab#27084
1d17542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jthano jthano

Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

make EigenProblem consistent with FEProblem when solve=false jthano/moose
2 participants
@lindsayad @jthano