Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Functional expansion tools module is not properly registering its objects in downstream apps #27637

Closed
GiudGiud opened this issue May 15, 2024 · 7 comments
Closed

Functional expansion tools module is not properly registering its objects in downstream apps #27637

GiudGiud opened this issue May 15, 2024 · 7 comments
Assignees
@GiudGiud
Labels
C: Modules/Functional Expansion Tools Tickets pertaining to the functional_expansion_tools module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented May 15, 2024 •
edited
Loading

Bug Description

FET objects could not be used by apps compiled with the FET module

Steps to Reproduce

Create or use an app
Add FET to the Makefile
Watch it not register FET objects by either running an input with FET objects or looking at the syntax dump

Impact

Users needed to rely on combined executable
@GiudGiud GiudGiud added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. C: Modules/Functional Expansion Tools Tickets pertaining to the functional_expansion_tools module labels May 15, 2024
@GiudGiud GiudGiud self-assigned this May 15, 2024
@lindsayad
Copy link
Member

Is somebody actually trying to use the module?!

GiudGiud added a commit to GiudGiud/moose that referenced this issue May 15, 2024
@GiudGiud
Fix registration for the FET module
07be929 
closes idaholab#27637
@GiudGiud
Copy link
Contributor Author

yes! at MIT a student looking at openmc-moose coupling

@GiudGiud
Copy link
Contributor Author

but goes to show how much it's used

@lindsayad
Copy link
Member

indeed. This is one of the earliest projects I assisted on when I joined the MOOSE team. Hasn't been touched by anyone since

@GiudGiud
Copy link
Contributor Author

GiudGiud commented May 15, 2024 •
edited
Loading

yeah there s a ton left to do there.
I dont think Zernike are actually what we want to represent these fields (concentration, temperature, power, density, ?) on the fuel pins, and there's plenty to do for other fuel types (TRISO, lightbridge, msrs ...)

@lindsayad
Copy link
Member

it would be awesome to see more development/use

@GiudGiud
Copy link
Contributor Author

GiudGiud commented May 15, 2024 •
edited
Loading

might be able to write a CINR from the joint appointment maybe
@bforget would you want to have another student on that?

ke7kto pushed a commit to ke7kto/moose that referenced this issue May 22, 2024
@GiudGiud @ke7kto
Fix registration for the FET module
cbfab55 
closes idaholab#27637
pbehne pushed a commit to pbehne/moose that referenced this issue Jun 12, 2024
@GiudGiud @pbehne
Fix registration for the FET module
0d0446a 
closes idaholab#27637
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GiudGiud GiudGiud

Labels
C: Modules/Functional Expansion Tools Tickets pertaining to the functional_expansion_tools module P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lindsayad @GiudGiud