Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make MOOSE compilable --with-strict-petscerrorcode #27784

Closed
lindsayad opened this issue Jun 4, 2024 · 0 comments · Fixed by #27785
Closed

Make MOOSE compilable --with-strict-petscerrorcode #27784

lindsayad opened this issue Jun 4, 2024 · 0 comments · Fixed by #27785
Labels
T: task An enhancement to the software.

Comments

@lindsayad
Copy link
Member

Motivation

Some PETSc devs/users only configure PETSc --with-strict-petscerrorcode, so if they want to look at MOOSE they cannot do so out of the box unless we are compliant with that configure option.

Design

Catch PETSc return codes and check them

Impact

Make MOOSE compatible with a broader range of PETSc configurations
@lindsayad lindsayad added the T: task An enhancement to the software. label Jun 4, 2024
lindsayad added a commit to lindsayad/moose that referenced this issue Jun 4, 2024
@lindsayad
Make MOOSE compliant --with-strict-petscerrorcode
85398d8 
Closes idaholab#27784
@lindsayad lindsayad mentioned this issue Jun 4, 2024
Merged
lindsayad added a commit to lindsayad/moose that referenced this issue Jun 4, 2024
@lindsayad
Make MOOSE compliant --with-strict-petscerrorcode
94e3825 
Closes idaholab#27784
lindsayad added a commit to lindsayad/moose that referenced this issue Jun 6, 2024
@lindsayad
return PETSC_SUCCESS -> PetscFunctionReturn(PETSC_SUCCESS)
24002af 
Refs idaholab#27784
lindsayad added a commit to lindsayad/moose that referenced this issue Jun 6, 2024
@lindsayad
Matching PetscFunctionReturn/PetscFunctionBegin
07f72be 
Refs idaholab#27784
abanki1 pushed a commit to abanki1/moose that referenced this issue Jul 11, 2024
@lindsayad
Make MOOSE compliant --with-strict-petscerrorcode
d7f791b 
Closes idaholab#27784
abanki1 pushed a commit to abanki1/moose that referenced this issue Jul 11, 2024
@lindsayad
return PETSC_SUCCESS -> PetscFunctionReturn(PETSC_SUCCESS)
8ebb2b8 
Refs idaholab#27784
abanki1 pushed a commit to abanki1/moose that referenced this issue Jul 11, 2024
@lindsayad
Matching PetscFunctionReturn/PetscFunctionBegin
cbac6a1 
Refs idaholab#27784
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make MOOSE compliant --with-strict-petscerrorcode lindsayad/moose
1 participant
@lindsayad