Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent terminology in tasks names #27912

Open
GiudGiud opened this issue Jun 16, 2024 · 0 comments
Open

Consistent terminology in tasks names #27912

GiudGiud opened this issue Jun 16, 2024 · 0 comments
Labels
C: Framework T: task An enhancement to the software.

Comments

@GiudGiud
Copy link
Contributor

Motivation

To "create" an object we name tasks like:

  • add_function
  • setup_executioner / setup_predictor
  • create_problem

in Moose.C

it's not great because one does not know if there is a previous action doing the original creation before the 'setup' phase

Design

Consistent choice in verbs. Probably add_ for everything that is plural, and create_ for everything that is unique
or add_ for everything

Impact

Easier to develop in moose inner layer
@GiudGiud GiudGiud added C: Framework T: task An enhancement to the software. labels Jun 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C: Framework T: task An enhancement to the software.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GiudGiud