Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Right and left sidesets are swapped in TransfiniteMeshGenerator output #28049

Open
GiudGiud opened this issue Jul 2, 2024 · 1 comment
Open

Right and left sidesets are swapped in TransfiniteMeshGenerator output #28049

GiudGiud opened this issue Jul 2, 2024 · 1 comment
Assignees
@oanaoana
Labels
C: Meshing MeshGenerator system, mesh loading P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.

Comments

@GiudGiud
Copy link
Contributor

GiudGiud commented Jul 2, 2024 •
edited
Loading

Bug Description

Peter was trying to model a loop and stitch each component
He could not get the transfinite generator to stitch until the sidesets were flipped back to what's expected

he found other (unrelated) problems with the stitcher, we ll have to narrow down the problems there too.
I have a feeling the stitcher should prepare the meshes to make sure the ids/names maps are right after clearing

Steps to Reproduce

Look at the gold files in the transfinite mesh generator folder

Impact

Loss of time
Wrong results
@GiudGiud GiudGiud added T: defect An anomaly, which is anything that deviates from expectations. P: normal A defect affecting operation with a low possibility of significantly affects. C: Meshing MeshGenerator system, mesh loading labels Jul 2, 2024
@GiudGiud GiudGiud changed the title Right and left are swapped in TransfiniteMeshGenerator output Right and left sidesets are swapped in TransfiniteMeshGenerator output Jul 2, 2024
@oanaoana
Copy link
Contributor

oanaoana commented Jul 8, 2024 •
edited
Loading

The generator is hard-coded to accept a certain ordering of sides as described in the documentation, and as such coupling it with stitching needs extra care. This is due to the nature of the algorithm which automatically fills up the domain from side to side. I will gladly take a look to see what is the problem, and if an improvement is needed. What exactly should be visible in the gold files? Are they not reproducible anymore?

grmnptr added a commit to grmnptr/moose that referenced this issue Jul 8, 2024
@grmnptr
Restore correct boundary names. (idaholab#28049)
a14eea2
@grmnptr grmnptr mentioned this issue Jul 8, 2024
Merged
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 9, 2024
@grmnptr
Restore correct boundary names. (idaholab#28049)
52f42ff
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 9, 2024
@grmnptr
Restore correct boundary names. (idaholab#28049)
d3c8ab2
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 10, 2024
@grmnptr
Regold test files. (idaholab#28049)
8fb669a
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 11, 2024
@grmnptr
Add warning message to stitcher. (idaholab#28049)
044dc3e
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 15, 2024
@grmnptr
Polish the warning messages in the stitcher. (idaholab#28049)
05b9f0b
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 15, 2024
@grmnptr
Add option to merge boundary IDs to MeshRepairGenerator. (idaholab#28049
da8a575 
)
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 15, 2024
@grmnptr
Start transitioning towards boundary ID merges. (idaholab#28049)
2a607e8
@grmnptr grmnptr mentioned this issue Jul 15, 2024
Open
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 16, 2024
@grmnptr
MAke sure old tests pass. (idaholab#28049)
8879fb4
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 16, 2024
@grmnptr
Add common function for merging boundaryIDs. (idaholab#28049)
64b710f
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 16, 2024
@grmnptr
Add test input file for the warning. (idaholab#28049)
0f4ff5c
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 16, 2024
@grmnptr
Add test for repair mesh generator. (idaholab#28049)
c29c627
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 16, 2024
@grmnptr
Adjust documentation, correct typos and wrong parameter message. (ida…
01fd979 
…holab#28049)
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Extend the merging algorithm with nodesets too. (idaholab#28049)
84ac694
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Extend the merging algorithm with nodesets too. (idaholab#28049)
4090d34
freiler pushed a commit to freiler/moose that referenced this issue Jul 17, 2024
@grmnptr @freiler
Restore correct boundary names. (idaholab#28049)
7028e3a
freiler pushed a commit to freiler/moose that referenced this issue Jul 17, 2024
@grmnptr @freiler
Regold test files. (idaholab#28049)
7466812
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Modify flow-over-circle test in NS to reflect new behavior. (idaholab…
8455d11 
…#28049)
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Add warning message to stitcher. (idaholab#28049)
10562ef
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Polish the warning messages in the stitcher. (idaholab#28049)
ea5155c
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Add option to merge boundary IDs to MeshRepairGenerator. (idaholab#28049
010d449 
)
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Start transitioning towards boundary ID merges. (idaholab#28049)
9487d8d
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
MAke sure old tests pass. (idaholab#28049)
386f1d8
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Add common function for merging boundaryIDs. (idaholab#28049)
81f70e8
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Add test input file for the warning. (idaholab#28049)
b62c6b7
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Add test for repair mesh generator. (idaholab#28049)
4395411
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Adjust documentation, correct typos and wrong parameter message. (ida…
482421b 
…holab#28049)
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Extend the merging algorithm with nodesets too. (idaholab#28049)
00d9c0f
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 17, 2024
@grmnptr
Modify flow-over-circle test in NS to reflect new behavior. (idaholab…
a8451ec 
…#28049)
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 19, 2024
@grmnptr
Modify flow-over-circle test in NS to reflect new behavior. (idaholab…
9531d67 
…#28049)
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 19, 2024
@grmnptr
Move mesh preparation out of the conditional since we will use it eit…
cb2abcc 
…her way. (idaholab#28049)
grmnptr added a commit to grmnptr/moose that referenced this issue Jul 21, 2024
@grmnptr
Move mesh preparation out of the conditional since we will use it eit…
30c5992 
…her way. (idaholab#28049)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oanaoana oanaoana

Labels
C: Meshing MeshGenerator system, mesh loading P: normal A defect affecting operation with a low possibility of significantly affects. T: defect An anomaly, which is anything that deviates from expectations.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@oanaoana @GiudGiud