Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow turning off trap_fpe in debug mode #3614

Closed
wants to merge 2 commits into from

Conversation

permcody
Copy link
Member

closes #3595

@shanestafford this should enable you to use FP_INFINITY in your tests, just make sure that you using the cli_args option if you create a test that will run in debug mode to pass the --no-trap-fpe flag.

@moosebuild
Copy link
Contributor

Results of testing aa0dacf using moose_PR_pre_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/3975

@permcody permcody changed the title Allow turning of trap_fpe in debug mode Allow turning off trap_fpe in debug mode Jul 30, 2014
@moosebuild
Copy link
Contributor

Results of testing aa0dacf using moose_PR_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/3976

@jwpeterson
Copy link
Member

I still don't think you are supposed to use variables with two leading underscores...

The rules (which did not change in C++11):

Reserved in any scope, including for use as implementation macros:
* identifiers beginning with an underscore and an uppercase letter
* identifiers containing adjacent underscores (or "double underscore")
Reserved in the global namespaces:
* identifiers beginning with an underscore
Also, everything in the std namespace is reserved. (You are allowed to add template specializations, though.)

reference

@moosebuild
Copy link
Contributor

Results of testing 3f53fcb using moose_PR_pre_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/3996

@jwpeterson
Copy link
Member

@shanestafford can you try this branch, make sure it does what you want?

@permcody
Copy link
Member Author

@shanestafford in fact, I wouldn't mind having a simple test added to moose/test. We had a nan_test in misc/check_error but it has been skipped since Petsc 3.4 because PETSc catches nans now. The FP_INFINITY capability should probably be tested at the MOOSE level to ensure that it continues to function. Feel free to contribute the computation that you want tested.

@moosebuild
Copy link
Contributor

Results of testing 3f53fcb using moose_PR_test recipe:

Passed on: linux

View the results here: https://www.moosebuild.com/view_job/3997

@shanestafford
Copy link

I'll add it to the hydride test and report back.

@shanestafford
Copy link

Status update: the branch does fix the test that failed (linux-gcc on a test that is not in MOOSE).

However, testing this change in MOOSE is proving to be difficult since most of the exp(-A/T) functions are in material models outside of MOOSE. Apparently, the parsed function does not respect the same fpe flags, so it is not possible to do something trivial like a FunctionAux with function = 'exp(-1/t)' to test this. There are some exp functions inside of solid_mechanics that I will try next.

@permcody
Copy link
Member Author

permcody commented Aug 4, 2014

Feel free to muck with one of the test material objects in moose/test/src/materials, that's what they're there for. Just add another flag to trigger the desired computation on demand. We already have other tests in the suite that do this.

@shanestafford shanestafford mentioned this pull request Aug 4, 2014
@permcody
Copy link
Member Author

permcody commented Aug 4, 2014

Closed in #3649

@permcody permcody closed this Aug 4, 2014
@permcody permcody deleted the allow_fpe_off_3595 branch August 12, 2014 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants