Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework on the switch statement for decomposition methods in ComputeFiniteStrain #7887

Merged
merged 2 commits into from Oct 19, 2016
Merged

rework on the switch statement for decomposition methods in ComputeFiniteStrain #7887

merged 2 commits into from Oct 19, 2016

Conversation

hchen139
Copy link
Contributor

closes #7886

@hchen139
Copy link
Contributor Author

@bwspenc @permcody Scoped enum for the switch statement in ComputeFiniteStrain.

dschwen
dschwen approved these changes Oct 18, 2016
View reviewed changes
Copy link
Member

@dschwen dschwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks nice!

@bwspenc
Copy link
Contributor

bwspenc commented Oct 18, 2016

Looks good. My only comment is that I don't think you have to use all caps in the input file (because it's not case sensitive), so you can still use the old form:
decomposition_method = EigenSolution
which is maybe more consistent with other input parameters.

@YaqiWang YaqiWang mentioned this pull request Oct 18, 2016
Merged
dschwen
dschwen reviewed Oct 18, 2016
View reviewed changes
modules/tensor_mechanics/src/materials/ComputeFiniteStrain.C
@@ -220,6 +220,6 @@ ComputeFiniteStrain::computeQpIncrements(RankTwoTensor & total_strain_increment,
}

default:
mooseError("ComputeFiniteStrain Error: Pass valid decomposition type: TAYLOREXPANSION or EIGENSOLUTION.");
mooseError("ComputeFiniteStrain Error: Pass valid decomposition type: TaylorExpansion or EigenSolution.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation :-D

@dschwen dschwen merged commit dfe29a2 into idaholab:devel Oct 19, 2016
@hchen139 hchen139 deleted the eigen_solution branch October 25, 2016 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dschwen dschwen dschwen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hchen139 @bwspenc @dschwen