Check to see if a function name could evaluate to a parsed function #8412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If people do that it is retarded. Just delete those function blocks and the tests/inputs should still pass/run. |
dschwen
reviewed
Jan 27, 2017
| @@ -29,5 +29,9 @@ AddFunctionAction::AddFunctionAction(InputParameters params) : | |||
| void | |||
| AddFunctionAction::act() | |||
| { | |||
| FunctionParserBase<Real> fp; | |||
| std::string vars = "x,y,z,t,NaN,pi,e"; | |||
There was a problem hiding this comment.
we may want to make this a static constant member
There was a problem hiding this comment.
Ah, wait, this only occurs in libmesh. Well, nevermind then.
There was a problem hiding this comment.
Nope, the same string appears in FEProblemBase::getFunction. No big deal, but this was changed before (when NaN was added by Roy).
There was a problem hiding this comment.
Yes, that is where I grabbed it. It would be nice if this sort of thing lived in a common place.
brianmoose
force-pushed
the
function-conflict-7659
branch
from
60e8eab
to
3569c25
Compare
|
Job |
1 similar comment
|
Job |
brianmoose
force-pushed
the
function-conflict-7659
branch
from
3569c25
to
f1c5891
Compare
dschwen
approved these changes
Feb 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just gives a warning, wasn't sure if it should be an error.
This also ignores
ParsedFunctions. There seems to be several places where peoplehave something like:
I wasn't sure if you wanted to warn/error there as well.
closes #7659