Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the failed test on Mac for subdomain partitioner interface #8950

Merged
merged 2 commits into from Apr 18, 2017

Conversation

fdkong
Copy link
Contributor

@fdkong fdkong commented Apr 18, 2017

There was a mistake when rebased the code by taking head changes. We need to add subdomain_partitioner into MooseEnum .

Refs #8672

@moosebuild
Copy link
Contributor

Job Precheck:linux-gnu on 38e1d2f wanted to post the following:

Your code requires style changes.
In the top level of your repository, you can run:

git clang-format 583badf8b5e51d7acd3e1f12eed2b76dc4b1dbff

Alternatively, apply the patch found here.
You can directly apply the patch by running:

curl -s http://mooseframework.org/docs/PRs/8950/style.patch | git apply -v

@fdkong fdkong force-pushed the SubdomainPartitioner_interface_fix branch from 38e1d2f to 43ebfa8 Compare April 18, 2017 15:01
@jwpeterson
Copy link
Member

There was a mistake when rebased the code by taking head changes.

I still don't see how this passed all the testing on devel and master.

@jwpeterson
Copy link
Member

I still don't see how this passed all the testing on devel and master.

Oh I see now, the test is restricted to Mac because of architecture-dependent partitioning differences...

@fdkong
Copy link
Contributor Author

fdkong commented Apr 18, 2017

I am going to add a linux test as well.

@permcody
Copy link
Member

#8948 will repair the broken test you are currently seeing on the Mac side.

@permcody
Copy link
Member

Failed test is unrelated to the PR.

@permcody permcody merged commit 7c585e3 into idaholab:devel Apr 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants