Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow RunException to fail tests correctly #10909

Merged
merged 3 commits into from Feb 28, 2018
Merged

Allow RunException to fail tests correctly #10909

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06902e4
Allow RunException to fail tests correctly
milljm Feb 26, 2018
fdda9b1
Exit with a non-zero
milljm Feb 26, 2018
0ef0fdf
line_sample_error should not exit(1) cleanly
milljm Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/TestHarness/testers/RunException.py
View file
Open in desktop
Expand Up @@ -67,7 +67,7 @@ def processResults(self, moose_dir, options, output):
output += "#"*80 + "\n\nUnable to match the following pattern against the program's output:\n\n" + specs['expect_err'] + "\n"

if reason == '':
RunApp.testFileOutput(self, moose_dir, options, output)
reason = RunApp.testFileOutput(self, moose_dir, options, output)
Copy link
Member Author

@milljm milljm Feb 26, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woops :)
If RunApp.testFileOutput set this test as failed, this test would later (the next few lines) set it as pass.


if reason != '':
self.setStatus(reason, self.bucket_fail)
Expand Down
13 changes: 9 additions & 4 deletions test/tests/misc/check_error/tests
View file
Open in desktop
Expand Up @@ -92,16 +92,16 @@
[../]

[./deprecated_param_default]
type = 'RunException'
type = 'RunApp'
input = 'deprecated_param_test.i'
expect_err = "The parameter \w+ is deprecated."
expect_out = "The parameter \w+ is deprecated."
cli_args = 'Kernels/nan/deprecated_default=1'
[../]

[./deprecated_param_no_default]
type = 'RunException'
type = 'RunApp'
input = 'deprecated_param_test.i'
expect_err = "The parameter \w+ is deprecated."
expect_out = "The parameter \w+ is deprecated."
cli_args = 'Kernels/nan/deprecated_no_default=1'
[../]

Expand Down Expand Up @@ -611,4 +611,9 @@
input = 'coupling_itself.i'
expect_err = "Coupled variable 'v' needs to be different from 'variable' with CoupledForce"
[../]
[./missing_input]
type = 'RunException'
input = 'missing_input_file.i'
expect_err = "Unable to open file"
[../]
[]