Fix meshed gap tests #12548
Merged
Fix meshed gap tests #12548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…b#12499 If a node is close to equal distance between two competing faces, there was inconsistent behavior, which caused a test to diff on HPC. Fall into the case where the faces are treated as being equidistant when you fall within tolerance now.
These tests were generating a bunch of errors because the temperatures were right around 0. Increase the temperature to get around that. Also, re-gold the meshed_annulus case because of the code change to the contact face competition when the faces are equal distance from a node within tolerance.
|
@friedmud I'm requesting your review on this because you added this test originally. It was platform-dependent because the nodes are equidistant to two faces within numerical tolerance. It behaves in a deterministic way now, and it passes on both mac and hpc for me. @aeslaughter FYI |
|
Job Documentation on 147ac98 wanted to post the following: View the site here This comment will be updated on new commits. |
aeslaughter
approved these changes
Nov 28, 2018
|
@bwspenc and @aeslaughter thanks for cleaning up something from my past. I've been a bit focused on other things lately... |
|
@friedmud No worries. Turns out that the problem originated in code I wrote. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12499