New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit dynamics #14658
Explicit dynamics #14658
Conversation
Job Documentation on e875638 wanted to post the following: View the site here This comment will be updated on new commits. |
I've just looked through the framework stuff in an attempt to understand what's going on with the preset issue we discussed today. I would suggest with the solution state access to just point to the solution, old solution, and older solution vectors for the states 0-2, instead of making more vectors and copying. Then add more as necessary for states 3+. It would make sense for |
@loganharbour that makes sense. I need to figure out how to do that though. I'll stop by later and ask you if you don't mind. |
@loganharbour, thanks for reviewing this PR. I agree with your comment on not adding extra vectors for solution states 0 to 2 and instead making it point to the existing vectors for current, old and older solutions. @cbolisetti, please let me know if you need any help with addressing the comments or if you would like me to make any changes to the framework part. Thanks! |
Job Precheck on 56de571 : invalidated by @cbolisetti |
I've re-written the solution state methods in order to use the current vectors. Only thing I'm stuck on now is if the dot dot, dot old, etc, methods need to be generalized as well. @cbolisetti I've looked around for you today but didn't see you around. |
@loganharbour thats great, thank you. I was busy yesterday. I'll stop by today. |
Job Test timings on 1b37911 wanted to post the following: View timings here This comment will be updated on new commits. |
cf688f9
to
34ab69d
Compare
Job Documentation on 34ab69d : invalidated by @loganharbour Writing doc timed out again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only large concern here is the lack of an interface for accessing the nodal residual values
modules/tensor_mechanics/include/nodalkernels/NodalRotationalInertia.h
Outdated
Show resolved
Hide resolved
modules/tensor_mechanics/src/nodalkernels/NodalTranslationalInertia.C
Outdated
Show resolved
Hide resolved
34ab69d
to
a9984c4
Compare
Took care of merge conflicts. I need a review for the last commit (mine), and we should have a discussion about an interface for the nodal residual values as seen in |
Yes, let's talk when you are back next week. One of the tests is failing now though. |
Looks unrelated - passing now. Sounds good for next week. |
All jobs on 1b37911 : invalidated by @loganharbour Re-try with fixed race conditions |
87a44ba
to
a6f23be
Compare
a6f23be
to
cabd404
Compare
51cee16
to
b2cde78
Compare
a23638e
to
cfb18bd
Compare
Job Precheck on cfb18bd wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
71bd18a
to
c2d2262
Compare
c2d2262
to
6f3ba4c
Compare
6f3ba4c
to
bec8a12
Compare
bec8a12
to
3e5f74c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approval for the commits that aren't mine (modules, modules doco, etc).
Job Private App tests on e875638 : invalidated by @loganharbour |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My approval for the commits that aren't mine.
Should CentralDifference and NewmarkBeta stay in framework or in tensor_mechanics? |
I'm fine with moving it - that's probably the best bet here. This has sat around for far too long, I'm going to merge now and will put up a smaller PR for that plus a few other things. |
Okay that makes sense. Thanks to you all @cbolisetti @sveerara @loganharbour I really appreciate all your work! |
This is a recreation of PR #12730 and an alternative to the formulation in PR #12628.
This PR demonstrates a formulation of the explicit dynamics solver that does not interfere with the current implementation of ActuallyExplicitEuler. This can be considered option 2 for an explicit dynamics formulation, option 1 being PR #12628 implemented by @hugary1995. This PR is the barebones version of the formulation intended for discussions geared towards a consensus on the design. Currently, the following are included in this PR:
InertialForce
,NodalTranslationalInertia
,NodalRotationalInertia
) so that the inertia kernels are timeintegrator-agnostic and will provide the right residual and Jacobian regardless of the timeintegrator.FunctionDirichletBCs
in the test input files to get them working. I am not yet sure why this happens.Tagging @sveerara @bwspenc @recuero