Refactor parsed material backend and add ADParsedMaterial #15331

dschwen · 2020-05-21T14:53:10Z

This mostly lays the groundwork for dual number support in Parsed and Derivative parsed Materials. This includes a libmesh update to allow for JIT compilation with dual numbers.

Refs #15207

moosebuild · 2020-05-21T14:55:22Z

Job Precheck on a89efcc wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/15331/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format bb526784f0d3d430f65655b691036d0e679d75e1

moosebuild · 2020-05-21T14:55:24Z

libmesh

@@ -1 +1 @@
-Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
+Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1


Caution! This contains a submodule update

moosebuild · 2020-05-21T15:30:58Z

libmesh

@@ -1 +1 @@
-Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
+Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1


Caution! This contains a submodule update

moosebuild · 2020-05-22T14:40:57Z

libmesh

@@ -1 +1 @@
-Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
+Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1


Caution! This contains a submodule update

moosebuild · 2020-05-22T23:48:27Z

libmesh

@@ -1 +1 @@
-Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
+Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1


Caution! This contains a submodule update

moosebuild · 2020-05-22T23:53:40Z

libmesh

@@ -1 +1 @@
-Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
+Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1


Caution! This contains a submodule update

moosebuild · 2020-05-23T19:07:39Z

libmesh

@@ -1 +1 @@
-Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
+Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1


Caution! This contains a submodule update

moosebuild · 2020-05-23T19:13:05Z

libmesh

@@ -1 +1 @@
-Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
+Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1


Caution! This contains a submodule update

dschwen · 2020-05-23T19:25:57Z

Why is a PR that contains a libmesh update tested against a two week old conda libmesh package?! What is the workflow supposed to be now?

dschwen · 2020-05-23T20:32:07Z

External App tests (Conda libMesh) is a misleading name, as it builds the libmesh submodule and does not use the conda package.

lindsayad · 2020-05-26T18:33:57Z

You will want to change "version" in conda/libmesh/meta.yaml, a la here

You need to do some change in the conda/libmesh directory (a change observable through git diff) in order to trigger a new conda build. Editing the version is a sufficient change

dschwen · 2020-05-26T19:33:32Z

You need to do some change in the conda/libmesh directory (a change observable through git diff) in order to trigger a new conda build. Editing the version is a sufficient change

Ok, cool. Apparently I didn't pay attention in class when the new workflow was introduced...

moosebuild · 2020-05-26T19:34:30Z

libmesh

@@ -1 +1 @@
-Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
+Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1


Caution! This contains a submodule update

lindsayad

I think this looks really good @dschwen

lindsayad · 2020-05-26T21:36:02Z

framework/include/utils/FunctionParserUtils.h

+  using FunctionParserUtils<T>::_eval_error_msg;                                                   \
+  using FunctionParserUtils<T>::_func_params
+
+// Helper class to pic the correct function parser


particle in cell?

lindsayad · 2020-05-26T22:46:46Z

framework/src/materials/ParsedMaterialHelper.C

  // fill the parameter vector, apply tolerances
  for (unsigned int i = 0; i < _nargs; ++i)
  {
    if (_tol[i] < 0.0)
      _func_params[i] = (*_args[i])[_qp];
    else
    {
-      a = (*_args[i])[_qp];
+      auto a = (*_args[i])[_qp];


I'm always curious whether to optimize for the probably much more popular use case which is builtins vs. optimize for the potentially much more expensive but maybe much less used user-defined type. I'll let you decide whether you want to copy here or catch as const auto &

Since FParser doesn't know MooseArrays I have to prepare a separate parameter vector. Good point about the copying though. I could add a separate mode in which parameters are passed as a vector of pointers rather than a vector of copied values. I would prefer to leave that for the next steps though.

dschwen · 2020-05-27T01:14:09Z

Ah, I think now I'm seeing errors due to Gary's recent PR. I think we made some similar colliding changes.

hugary1995 · 2020-05-27T01:42:46Z

I came in to say thanks for this long-awaited PR until I saw my name.

dschwen · 2020-05-27T13:27:20Z

Ha, no worries. It is up to me to rebase and fix this!

moosebuild · 2020-05-27T14:43:46Z

libmesh

@@ -1 +1 @@
-Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
+Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1


Caution! This contains a submodule update

moosebuild · 2020-05-27T17:48:35Z

Job Mac Test on 9f2d896 : invalidated by @milljm

Deleted stale environment

dschwen · 2020-05-28T03:42:09Z

I have a marmot PR ready

moosebuild · 2020-05-28T04:33:01Z

large_media

@@ -1 +1 @@
-Subproject commit 7b841db905481fcdd53fa823184861fa1061960f
+Subproject commit f7c572fcde16c25fff3bc2fc69a4f92f555bd945


Caution! This contains a submodule update

moosebuild · 2020-05-28T06:46:06Z

Job Documentation on 9703f7e wanted to post the following:

View the site here

This comment will be updated on new commits.

dschwen · 2020-05-28T13:51:34Z

@lindsayad the ~~Zapdos~~Crane fix should be easy as well. ADFunctionPtr is now called SymFunctionPtr, and FunctionParserUtils is now an is_ad template, so make that FunctionParserUtils<false>.

dschwen · 2020-05-28T13:52:49Z

Oh, ~~Zapdos~~Crane is public. I guess I'll just make a PR myself then!

dschwen · 2020-05-28T16:00:14Z

Crane PR: lcpp-org/crane#58
Marmot MR: https://hpcgitlab.hpc.inl.gov/idaholab/marmot/-/merge_requests/520

lindsayad

Very exciting stuff

lindsayad · 2020-05-28T23:49:31Z

framework/src/utils/ADFParser.C

+  auto result =
+      JITCompileHelper("DualReal",
+                       ADFPARSER_INCLUDES,
+                       "#include \"DualReal.h\"\n#include \"metaphysicl/dualnumberarray.h\"\n");


@dschwen I should have caught this on review. Just #include ADReal.h and that should get you everything you need.

ah, cool, I'll make a fixup PR

moosebuild reviewed May 21, 2020

View reviewed changes

dschwen force-pushed the aderivativeparsed_15207 branch 2 times, most recently from 2e8cb8c to 68d7bc4 Compare May 21, 2020 22:45

moosebuild reviewed May 22, 2020

View reviewed changes

dschwen force-pushed the aderivativeparsed_15207 branch from 2f6d5b4 to 57554a1 Compare May 22, 2020 23:45

moosebuild reviewed May 22, 2020

View reviewed changes

dschwen force-pushed the aderivativeparsed_15207 branch from 57554a1 to 58a1685 Compare May 22, 2020 23:51

moosebuild reviewed May 22, 2020

View reviewed changes

dschwen force-pushed the aderivativeparsed_15207 branch from 58a1685 to db3927f Compare May 23, 2020 19:05

moosebuild reviewed May 23, 2020

View reviewed changes

dschwen force-pushed the aderivativeparsed_15207 branch from db3927f to 704a259 Compare May 23, 2020 19:10

moosebuild reviewed May 23, 2020

View reviewed changes

dschwen requested a review from lindsayad May 26, 2020 18:15

dschwen force-pushed the aderivativeparsed_15207 branch from 704a259 to 498c0da Compare May 26, 2020 19:32

moosebuild reviewed May 26, 2020

View reviewed changes

lindsayad reviewed May 26, 2020

View reviewed changes

dschwen force-pushed the aderivativeparsed_15207 branch from 498c0da to 9f2d896 Compare May 27, 2020 14:39

moosebuild reviewed May 27, 2020

View reviewed changes

Templatify (idaholab#15207)

f271d04

dschwen and others added 9 commits May 27, 2020 22:29

Add DualReal JIT class (idaholab#15207)

ece9413

Add unit test (idaholab#15207)

56c5563

Parsed material (idaholab#15207)

f98dfdf

Address comments (idaholab#15207)

06b5b64

Add more generic access functions (idaholab#15207)

a2fcc53

Using delcarations for member templates forbidden (idaholab#15207)

fffa56c

Update libmesh (idaholab#15207)

1926323

Fix up generic types stuff (idaholab#15207)

ed60f27

Fix tests (idaholab#15207)

9703f7e

dschwen force-pushed the aderivativeparsed_15207 branch from 9f2d896 to 9703f7e Compare May 28, 2020 04:30

moosebuild reviewed May 28, 2020

View reviewed changes

This was referenced May 28, 2020

Upcoming API change in MOOSE lcpp-org/crane#57

Closed

Update for API changes lcpp-org/crane#58

Merged

lindsayad approved these changes May 28, 2020

View reviewed changes

lindsayad merged commit 67edce1 into idaholab:next May 28, 2020

lindsayad mentioned this pull request May 28, 2020

Regold Test for libMesh#2584 #15352

Merged

dschwen mentioned this pull request May 28, 2020

Update moose and crane submodules after API change shannon-lab/zapdos#61

Closed

lindsayad reviewed May 28, 2020

View reviewed changes

dschwen added a commit to dschwen/moose that referenced this pull request May 29, 2020

Fix include (idaholab#15331)

078cd56

dschwen added a commit to dschwen/moose that referenced this pull request May 29, 2020

Use ADReal everywhere (idaholab#15331)

91d64c6

dschwen mentioned this pull request May 29, 2020

Fix sparse dual numbers in AD parsed material pull request #15359

Merged

dschwen added a commit to dschwen/moose that referenced this pull request May 29, 2020

Use ADReal everywhere (idaholab#15331)

adfd54b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor parsed material backend and add ADParsedMaterial #15331

Refactor parsed material backend and add ADParsedMaterial #15331

dschwen commented May 21, 2020

moosebuild commented May 21, 2020

moosebuild May 21, 2020

moosebuild May 21, 2020

moosebuild May 22, 2020

moosebuild May 22, 2020

moosebuild May 22, 2020

moosebuild May 23, 2020

moosebuild May 23, 2020

dschwen commented May 23, 2020 •

edited

Loading

dschwen commented May 23, 2020

lindsayad commented May 26, 2020 •

edited

Loading

dschwen commented May 26, 2020

moosebuild May 26, 2020

lindsayad left a comment

lindsayad May 26, 2020

lindsayad May 26, 2020

dschwen May 27, 2020

dschwen commented May 27, 2020

hugary1995 commented May 27, 2020

dschwen commented May 27, 2020

moosebuild May 27, 2020

moosebuild commented May 27, 2020

dschwen commented May 28, 2020

moosebuild May 28, 2020

moosebuild commented May 28, 2020

dschwen commented May 28, 2020 •

edited

Loading

dschwen commented May 28, 2020 •

edited

Loading

dschwen commented May 28, 2020

lindsayad left a comment

lindsayad May 28, 2020

dschwen May 28, 2020

		@@ -1 +1 @@
		Subproject commit 30d38fc9b5bc608655d033117a8d5cb59c57ae4c
		Subproject commit cd8b4510adc28c1b480dda33cb7f449831f2fad1

		@@ -1 +1 @@
		Subproject commit 7b841db905481fcdd53fa823184861fa1061960f
		Subproject commit f7c572fcde16c25fff3bc2fc69a4f92f555bd945

Refactor parsed material backend and add ADParsedMaterial #15331

Refactor parsed material backend and add ADParsedMaterial #15331

Conversation

dschwen commented May 21, 2020

moosebuild commented May 21, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dschwen commented May 23, 2020 • edited Loading

dschwen commented May 23, 2020

lindsayad commented May 26, 2020 • edited Loading

dschwen commented May 26, 2020

Choose a reason for hiding this comment

lindsayad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dschwen commented May 27, 2020

hugary1995 commented May 27, 2020

dschwen commented May 27, 2020

Choose a reason for hiding this comment

moosebuild commented May 27, 2020

dschwen commented May 28, 2020

Choose a reason for hiding this comment

moosebuild commented May 28, 2020

dschwen commented May 28, 2020 • edited Loading

dschwen commented May 28, 2020 • edited Loading

dschwen commented May 28, 2020

lindsayad left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dschwen commented May 23, 2020 •

edited

Loading

lindsayad commented May 26, 2020 •

edited

Loading

dschwen commented May 28, 2020 •

edited

Loading

dschwen commented May 28, 2020 •

edited

Loading