Remove all empty 'issues' and complete class descriptions for framework #15971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aeslaughter
added this to In progress
in FY21 SQA Documentation and Improvements
via automation
|
Job Documentation on 6492363 wanted to post the following: View the site here This comment will be updated on new commits. |
aeslaughter
force-pushed
the
sqa-15968
branch
from
151442b
to
4b63c82
Compare
zachmprince
reviewed
Oct 17, 2020
|
Yes, some of are tests are old enough to not have a ticket reference. So, I
just use the hash for when it was first committed, so at least you can find
that information easily.
…On Fri, Oct 16, 2020 at 6:12 PM Zachary Prince ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In test/tests/auxkernels/element_var/tests
<#15971 (comment)>:
> @@ -1,6 +1,6 @@
[Tests]
design = 'syntax/AuxKernels/index.md'
- issues = ''
+ issues = '16769b212846275cd8b12e5a89b9e98f3ab7ca83 #238'
What's going on here? Is that a commit hash?
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#15971 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACTKVL7TWOVY5UA4DALKBLSLDONNANCNFSM4STYJJGQ>
.
|
aeslaughter
force-pushed
the
sqa-15968
branch
3 times, most recently
from
95671d2
to
725b452
Compare
aeslaughter
force-pushed
the
sqa-15968
branch
2 times, most recently
from
8b9e2c4
to
b2c9f5e
Compare
aeslaughter
force-pushed
the
sqa-15968
branch
from
b2c9f5e
to
2875475
Compare
aeslaughter
changed the title
aeslaughter
force-pushed
the
sqa-15968
branch
2 times, most recently
from
89719ed
to
1dec88d
Compare
This was referenced Oct 31, 2020
aeslaughter
force-pushed
the
sqa-15968
branch
from
aa1185b
to
7b181da
Compare
aeslaughter
commented
Nov 3, 2020
| @@ -79,7 +79,7 @@ def check_requirements(requirements, file_list=None, color_text=True, **kwargs): | |||
| raise ValueError(msg) | |||
| elif file_list is None: | |||
| root = mooseutils.git_root_dir() | |||
| file_list = mooseutils.git_ls_files(root, recurse_submodules=False) | |||
| file_list = mooseutils.git_ls_files(root, recurse_submodules=True) | |||
There was a problem hiding this comment.
@cbolisetti This should fix your MASTODON files not being found. I gave you the wrong file to change this in earlier in the day.
aeslaughter
commented
Nov 3, 2020
| @@ -468,8 +468,11 @@ def defaultSettings(): | |||
| def createTokenFromSyntax(self, parent, info, page, obj): | |||
|
|
|||
| primary = SyntaxList(None, **self.attributes) | |||
| if self.settings['groups']: | |||
There was a problem hiding this comment.
@joshuahansel @cbolisetti I am hoping this fixes the syntax list problems you are seeing in your apps
aeslaughter
force-pushed
the
sqa-15968
branch
4 times, most recently
from
9949b06
to
650f590
Compare
aeslaughter
force-pushed
the
sqa-15968
branch
from
650f590
to
6492363
Compare
loganharbour
approved these changes
Nov 5, 2020
aeslaughter
added a commit
to aeslaughter/moose
that referenced
this pull request
Mar 2, 2021
aeslaughter
added a commit
to aeslaughter/moose
that referenced
this pull request
Mar 2, 2021
aeslaughter
added a commit
to aeslaughter/moose
that referenced
this pull request
Mar 2, 2021
aeslaughter
added a commit
to aeslaughter/moose
that referenced
this pull request
Mar 2, 2021
jain651
pushed a commit
to jain651/moose
that referenced
this pull request
Apr 19, 2021
aeslaughter
added a commit
to aeslaughter/moose
that referenced
this pull request
Jun 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.