Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically select memory-efficient PtAP algorithms for HMG #16213

Merged
merged 3 commits into from Dec 3, 2020
Merged

Automatically select memory-efficient PtAP algorithms for HMG #16213

merged 3 commits into from Dec 3, 2020

Conversation

fdkong
Copy link
Contributor

@fdkong fdkong commented Nov 16, 2020 •
edited

Closes #16210

@moosebuild
Copy link
Contributor

moosebuild commented Nov 17, 2020 •
edited

Job Documentation on 80537db wanted to post the following:

View the site here

This comment will be updated on new commits.

@fdkong fdkong requested a review from lindsayad December 2, 2020 19:44
lindsayad
lindsayad requested changes Dec 2, 2020
View reviewed changes
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is very nice. Just a few small requests

framework/doc/content/source/preconditioners/HMGPreconditioner.md Outdated Show resolved Hide resolved
framework/doc/content/source/preconditioners/HMGPreconditioner.md Outdated Show resolved Hide resolved
framework/doc/content/source/preconditioners/HMGPreconditioner.md Outdated Show resolved Hide resolved
framework/doc/content/source/preconditioners/HMGPreconditioner.md Show resolved Hide resolved
framework/src/utils/PetscSupport.C Show resolved Hide resolved
test/tests/preconditioners/hmg/tests Outdated Show resolved Hide resolved
@YaqiWang
Copy link
Contributor

YaqiWang commented Dec 2, 2020

This is great. My only comment is that we need to update Griffin inputs and the inputs for performance benchmarks once this is pushed into Griffin.

@fdkong
Copy link
Contributor Author

fdkong commented Dec 2, 2020

It is ready for review or merge @lindsayad

lindsayad
lindsayad requested changes Dec 3, 2020
View reviewed changes
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't catch the doc thing last review

framework/doc/content/source/preconditioners/HMGPreconditioner.md Outdated Show resolved Hide resolved
framework/doc/content/source/preconditioners/HMGPreconditioner.md Show resolved Hide resolved
framework/src/utils/PetscSupport.C Show resolved Hide resolved
@fdkong fdkong merged commit 02f4ab4 into idaholab:next Dec 3, 2020
@fdkong fdkong deleted the hmg_options branch December 3, 2020 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsayad lindsayad lindsayad approved these changes

Assignees

@fdkong fdkong

Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto select memory-efficient algorithms for HMG
4 participants
@fdkong @moosebuild @YaqiWang @lindsayad