Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle stateful properties in xfem moving interface #16278

Merged
merged 7 commits into from
Jan 22, 2021

Conversation

hugary1995
Copy link
Contributor

@hugary1995 hugary1995 commented Nov 23, 2020

This is a reopening of stale PR #15818.
This PR handles stateful properties when an XFEM cut is healed and re-cut.

closes #15817

@hugary1995 hugary1995 changed the title Xfem heal stateful handle stateful properties in xfem moving interface Nov 23, 2020
@moosebuild
Copy link
Contributor

moosebuild commented Nov 23, 2020

Job Documentation on 56131a3 wanted to post the following:

View the site here

This comment will be updated on new commits.

@hugary1995
Copy link
Contributor Author

Pinging @bwspenc .

@bwspenc bwspenc self-assigned this Dec 1, 2020
@moosebuild
Copy link
Contributor

Job Documentation on 84af071 : invalidated by @bwspenc

@hugary1995 hugary1995 force-pushed the xfem_heal_stateful branch 2 times, most recently from 7918d2a to 73850b2 Compare December 2, 2020 17:29
framework/include/materials/MaterialData.h Outdated Show resolved Hide resolved
modules/xfem/include/base/XFEM.h Outdated Show resolved Hide resolved
modules/xfem/include/base/XFEM.h Show resolved Hide resolved
modules/xfem/include/userobjects/LevelSetCutUserObject.h Outdated Show resolved Hide resolved
modules/xfem/src/base/XFEM.C Outdated Show resolved Hide resolved
@hugary1995
Copy link
Contributor Author

Can someone help me invalidate the failing tests due to conda?

@loganharbour
Copy link
Member

Can someone help me invalidate the failing tests due to conda?

Looks good now.

Copy link
Contributor

@bwspenc bwspenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really close! Just a few little things to fix.

modules/xfem/include/userobjects/GeometricCutUserObject.h Outdated Show resolved Hide resolved
modules/xfem/include/userobjects/LevelSetCutUserObject.h Outdated Show resolved Hide resolved
modules/xfem/src/base/XFEM.C Outdated Show resolved Hide resolved
store stateful properties before healing, and set them back after re-cut.

close idaholab#15817
@moosebuild
Copy link
Contributor

Job Non unity build on e90f0db : invalidated by @bwspenc

Failure seems unrelated to this PR. Just checking.

@bwspenc bwspenc changed the title handle stateful properties in xfem moving interface Handle stateful properties in xfem moving interface Jan 14, 2021
bwspenc
bwspenc previously approved these changes Jan 14, 2021
@hugary1995
Copy link
Contributor Author

@rwcarlsen @bwspenc I just switched everything to use the API you suggested. But instead of changing the existing method using element references, I added a new method using pointers.

If we had been doing things correctly this should not break any test.

Copy link
Contributor

@rwcarlsen rwcarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All the original copy methods in MaterialData and MaterialPropertyStorage should just call the new functions you created - no need to duplicate all that code (i.e. copy(const Elem & ...) {copy(&elem_to, &elem_from...);}). And since the initProps function is just private/internal - you should just delete the old version and make all calls use the new version.

@bwspenc bwspenc merged commit fd9fa36 into idaholab:next Jan 22, 2021
@hugary1995 hugary1995 deleted the xfem_heal_stateful branch January 23, 2022 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xfem moving interface + stateful properties
7 participants