Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MeshGenerator::addMeshSubgenerator() api #17458

Merged
merged 18 commits into from Mar 31, 2021

Commits on Mar 29, 2021

  1. Fix misleading comment

    These names can be any mesh generator in the input file, they're not
    mesh filenames.
    roystgnr committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    22f402c View commit details
    Browse the repository at this point in the history
  2. Make StitchedMeshGenerator::generate more flexible

    If we don't assume that the index names and the mesh ptr vectors are the
    same size, then we can have subclasses that add additional mesh ptr
    entries from other sources.  This is useful for a test subclass I'm
    adding.
    roystgnr committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    4d144ce View commit details
    Browse the repository at this point in the history
  3. Extend StitchedMeshGenerator code and clone test

    The modified test will instantiate "subgenerators" itself instead of
    getting them from earlier in the input file.
    roystgnr committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    87092fb View commit details
    Browse the repository at this point in the history
  4. Add InputParameters::setParameters() method

    Template parameter packs are neat.
    
    More importantly, template parameter packs let us pass arbitrary
    parameters to set in the internals of another helper function.
    roystgnr committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    d811791 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    608d2a1 View commit details
    Browse the repository at this point in the history
  6. Add MeshGenerator::addMeshSubgenerator()

    Hopefully this is something like what the ANL folks had in mind for
    idaholab#17184
    roystgnr committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    78047cf View commit details
    Browse the repository at this point in the history
  7. Use addMeshSubgenerator in test code

    This turns several lines of slightly tricky code into 4 lines of
    arguably self-documenting code, so I'm fairly happy with it.
    roystgnr committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    2999d79 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    d390349 View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Update test/src/meshgenerators/StitchedSubgenerators.C

    Make subgenerator name base unique
    
    Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
    roystgnr and loganharbour committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    b75133c View commit details
    Browse the repository at this point in the history
  2. Remove legacy params syntax

    Thanks to @loganharbour for catching this
    roystgnr committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    c2f94c5 View commit details
    Browse the repository at this point in the history
  3. Style changes

    roystgnr committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    bee0322 View commit details
    Browse the repository at this point in the history
  4. Refactor to add InputParameters-accepting overload

    This overload is a little trickier to use but is more in line with some
    other MOOSE APIs.
    roystgnr committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    8d6122a View commit details
    Browse the repository at this point in the history
  5. Set _moose_app inside addMeshSubgenerator

    This lets users be a little less picky about how they construct their
    InputParameters without us hitting a failure at generate() time.
    roystgnr committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    0225b60 View commit details
    Browse the repository at this point in the history
  6. Test both variadic and plain addMeshSubgenerator()

    This way, if we ever add any more subtle parameters like _moose_app that
    ought to be set from within addMeshSubgenerator() itself, we'll catch
    the error in this test rather than in any user codes making use of the
    InputParameters-accepting overload.
    roystgnr committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    2208e32 View commit details
    Browse the repository at this point in the history
  7. git clang-format

    roystgnr committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    6b3d21a View commit details
    Browse the repository at this point in the history
  8. Update test/src/meshgenerators/StitchedSubgenerators.C

    This is a test object only
    
    Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
    roystgnr and loganharbour committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    83e439d View commit details
    Browse the repository at this point in the history
  9. Better test directory name, requirement

    Or a requirement that @loganharbour and I were both happy enough with,
    at least.
    roystgnr committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    095b4ee View commit details
    Browse the repository at this point in the history
  10. Rename StitchedSubgenerators -> TestSubgenerators

    Logan is insistant that test objects should be clearly labeled as such.
    
    Which makes sense, so I nominate him to fix the *other* 291 classes in
    test/src/*/ that don't have "Test" in the name.
    roystgnr committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    c7213e2 View commit details
    Browse the repository at this point in the history