New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MeshGenerator::addMeshSubgenerator() api #17458
Commits on Mar 29, 2021
-
These names can be any mesh generator in the input file, they're not mesh filenames.
Configuration menu - View commit details
-
Copy full SHA for 22f402c - Browse repository at this point
Copy the full SHA 22f402cView commit details -
Make StitchedMeshGenerator::generate more flexible
If we don't assume that the index names and the mesh ptr vectors are the same size, then we can have subclasses that add additional mesh ptr entries from other sources. This is useful for a test subclass I'm adding.
Configuration menu - View commit details
-
Copy full SHA for 4d144ce - Browse repository at this point
Copy the full SHA 4d144ceView commit details -
Extend StitchedMeshGenerator code and clone test
The modified test will instantiate "subgenerators" itself instead of getting them from earlier in the input file.
Configuration menu - View commit details
-
Copy full SHA for 87092fb - Browse repository at this point
Copy the full SHA 87092fbView commit details -
Add InputParameters::setParameters() method
Template parameter packs are neat. More importantly, template parameter packs let us pass arbitrary parameters to set in the internals of another helper function.
Configuration menu - View commit details
-
Copy full SHA for d811791 - Browse repository at this point
Copy the full SHA d811791View commit details -
Configuration menu - View commit details
-
Copy full SHA for 608d2a1 - Browse repository at this point
Copy the full SHA 608d2a1View commit details -
Add MeshGenerator::addMeshSubgenerator()
Hopefully this is something like what the ANL folks had in mind for idaholab#17184
Configuration menu - View commit details
-
Copy full SHA for 78047cf - Browse repository at this point
Copy the full SHA 78047cfView commit details -
Use addMeshSubgenerator in test code
This turns several lines of slightly tricky code into 4 lines of arguably self-documenting code, so I'm fairly happy with it.
Configuration menu - View commit details
-
Copy full SHA for 2999d79 - Browse repository at this point
Copy the full SHA 2999d79View commit details -
Configuration menu - View commit details
-
Copy full SHA for d390349 - Browse repository at this point
Copy the full SHA d390349View commit details
Commits on Mar 30, 2021
-
Update test/src/meshgenerators/StitchedSubgenerators.C
Make subgenerator name base unique Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for b75133c - Browse repository at this point
Copy the full SHA b75133cView commit details -
Thanks to @loganharbour for catching this
Configuration menu - View commit details
-
Copy full SHA for c2f94c5 - Browse repository at this point
Copy the full SHA c2f94c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for bee0322 - Browse repository at this point
Copy the full SHA bee0322View commit details -
Refactor to add InputParameters-accepting overload
This overload is a little trickier to use but is more in line with some other MOOSE APIs.
Configuration menu - View commit details
-
Copy full SHA for 8d6122a - Browse repository at this point
Copy the full SHA 8d6122aView commit details -
Set _moose_app inside addMeshSubgenerator
This lets users be a little less picky about how they construct their InputParameters without us hitting a failure at generate() time.
Configuration menu - View commit details
-
Copy full SHA for 0225b60 - Browse repository at this point
Copy the full SHA 0225b60View commit details -
Test both variadic and plain addMeshSubgenerator()
This way, if we ever add any more subtle parameters like _moose_app that ought to be set from within addMeshSubgenerator() itself, we'll catch the error in this test rather than in any user codes making use of the InputParameters-accepting overload.
Configuration menu - View commit details
-
Copy full SHA for 2208e32 - Browse repository at this point
Copy the full SHA 2208e32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b3d21a - Browse repository at this point
Copy the full SHA 6b3d21aView commit details -
Update test/src/meshgenerators/StitchedSubgenerators.C
This is a test object only Co-authored-by: Logan Harbour <loganhharbour@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 83e439d - Browse repository at this point
Copy the full SHA 83e439dView commit details -
Better test directory name, requirement
Or a requirement that @loganharbour and I were both happy enough with, at least.
Configuration menu - View commit details
-
Copy full SHA for 095b4ee - Browse repository at this point
Copy the full SHA 095b4eeView commit details -
Rename StitchedSubgenerators -> TestSubgenerators
Logan is insistant that test objects should be clearly labeled as such. Which makes sense, so I nominate him to fix the *other* 291 classes in test/src/*/ that don't have "Test" in the name.
Configuration menu - View commit details
-
Copy full SHA for c7213e2 - Browse repository at this point
Copy the full SHA c7213e2View commit details