Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework rename block generator #17711

Closed
wants to merge 6 commits into from
Closed

Rework rename block generator #17711

wants to merge 6 commits into from

Conversation

loganharbour
Copy link
Member

@loganharbour loganharbour commented Apr 29, 2021 •
edited

Closes #17710

  • old_block_id and old_block_name merged into old_block
  • new_block_id and new_block_name merged into new_block
  • Renaming is now independent of ordering (creates temp blocks as needed)
  • Removed old mesh modifier based tests for more exhaustive generator tests

@loganharbour loganharbour self-assigned this Apr 29, 2021
@loganharbour loganharbour mentioned this pull request Apr 29, 2021
Closed
@loganharbour
Copy link
Member Author

Still need to fix up the documentation.

@moosebuild
Copy link
Contributor

moosebuild commented Apr 29, 2021 •
edited

Job Documentation on a82016b wanted to post the following:

View the site here

This comment will be updated on new commits.

@WilkAndy
Copy link
Contributor

Please provide lots of examples in the markdown doco, since your changes substantially alter (for the better) the functionality. Eg old='1 2 3', new='2 3 4' made all blocks equal to '4' previously (because the convention was specified as "read the changes left to right") but now they become '2 3 4' which is more intuitive. Check that all the crazy possibilities mentioned in the current markdown doco are adequately covered by your code and by your new doco.

@loganharbour
Copy link
Member Author

@WilkAndy absolutely. I'm not quite to doco yet though with all of the red from the tests :-)

@loganharbour loganharbour force-pushed the rework_rename_block_generator branch 3 times, most recently from 1d827cd to 71680f3 Compare May 3, 2021 01:48
@loganharbour
Rework RenameBlockGenerator
7c23619 
- Remove _id and _name params to the single old_block and new_block params
- Allow merging that is independent of ordering

refs idaholab#17710
@loganharbour
Remove old rename block mesh modifier tests
fd7cdf1 
refs idaholab#17710
@loganharbour
Use new RenameBlockGenerator params
92163cd 
refs idaholab#17710
@loganharbour
Set sidesets and subdomains in MeshInfo to root
a82016b 
refs idaholab#17710
@loganharbour loganharbour force-pushed the rework_rename_block_generator branch from 71680f3 to a82016b Compare May 3, 2021 01:52
@stale
Copy link

stale bot commented Jun 26, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale PRs that have reached or exceeded 90 days with no activity label Jun 26, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

Closing due to 30 days of inactivity. See http://mooseframework.org/moose/framework_development/patch_to_code.html

@stale stale bot closed this Jul 21, 2021
@loganharbour loganharbour mentioned this pull request Nov 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@loganharbour loganharbour

Labels
stale PRs that have reached or exceeded 90 days with no activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix bug in RenameBlockGenerator
3 participants
@loganharbour @moosebuild @WilkAndy