Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused initPostprocessorData() #17973

Merged
merged 1 commit into from
Mar 13, 2022
Merged

Remove unused initPostprocessorData() #17973

merged 1 commit into from
Mar 13, 2022

Conversation

loganharbour
Copy link
Member

refs #17512

@loganharbour
Copy link
Member Author

Good to go after griffin #222 is in.

@loganharbour loganharbour self-assigned this May 31, 2021
@moosebuild
Copy link
Contributor

moosebuild commented May 31, 2021 •
edited

Job Documentation on 2837d58 wanted to post the following:

View the site here

This comment will be updated on new commits.

@loganharbour
Copy link
Member Author

@andrsd this should be good once the apps are updated for the week

@loganharbour loganharbour requested a review from andrsd June 1, 2021 22:03
GiudGiud
GiudGiud previously approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like it's passing already

@loganharbour
Copy link
Member Author

As you offended this in the past 😆 take note of "failed but allowed". I'd prefer not to break these applications until the dependencies are fixed: https://civet.inl.gov/job/750892/

@YaqiWang
Copy link
Contributor

YaqiWang commented Jun 3, 2021

lol. Are we still manually updating Griffin in all those apps?

andrsd
andrsd previously approved these changes Jun 7, 2021
View reviewed changes
@andrsd
Copy link
Contributor

andrsd commented Jun 7, 2021

Anybody patched SAM?

DireWolf and SBTH should be a matter of submodule update.

@loganharbour
Copy link
Member Author

Gonna merge once these tests are good again - @andrsd is taking care of crabby

@andrsd
Copy link
Contributor

andrsd commented Jun 14, 2021

Note that BlueCRAB will be failing until SAM is patched. SAM is a BlueCRAB dependency...

@idaholab idaholab deleted a comment from moosebuild Jun 15, 2021
@idaholab idaholab deleted a comment from moosebuild Jun 15, 2021
@loganharbour loganharbour dismissed stale reviews from andrsd and GiudGiud via 2f9c73d June 15, 2021 16:36
@idaholab idaholab deleted a comment from moosebuild Jun 24, 2021
@moosebuild
Copy link
Contributor

moosebuild commented Nov 15, 2021 •
edited

Job Coverage on 2837d58 wanted to post the following:

Framework coverage

2f149d #17973 2837d5
Total Total +/- New
Rate 82.42% 82.41% -0.00% -
Hits 73437 73436 -1 0
Misses 15669 15670 +1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

andrsd
andrsd previously approved these changes Nov 29, 2021
View reviewed changes
@loganharbour loganharbour added PR: Auto Merge Add this label to have CIVET merge on success and removed PR: Ready for review/merge labels Nov 29, 2021
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale PRs that have reached or exceeded 90 days with no activity label Mar 12, 2022
@loganharbour loganharbour removed the stale PRs that have reached or exceeded 90 days with no activity label Mar 13, 2022
@loganharbour loganharbour removed the PR: Auto Merge Add this label to have CIVET merge on success label Mar 13, 2022
@loganharbour
Copy link
Member Author

@cticenhour this has been good for a while - will also be my test for fixing the timing target

cticenhour
cticenhour approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@loganharbour loganharbour merged commit 58d6469 into idaholab:next Mar 13, 2022
@loganharbour loganharbour deleted the remove_init_pp branch March 13, 2022 23:14
@moosebuild
Copy link
Contributor

Job Test timings on 2837d58 wanted to post the following:

View timings here

This comment will be updated on new commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cticenhour cticenhour cticenhour approved these changes

@andrsd andrsd andrsd left review comments

@GiudGiud GiudGiud GiudGiud left review comments

@lindsayad lindsayad Awaiting requested review from lindsayad lindsayad is a code owner

Assignees

@loganharbour loganharbour

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@loganharbour @moosebuild @YaqiWang @andrsd @cticenhour @GiudGiud