Protect against failed point inversions due to interface kernels #18225
Conversation
|
Job Documentation on 62e4b53 wanted to post the following: View the site here This comment will be updated on new commits. |
lindsayad
force-pushed
the
displaced-face-czm-18175
branch
from
24f16e4
to
1e1b24b
Compare
| @@ -21,6 +21,18 @@ Interface kernels can be used to provide any general flux condition at an interf | |||
| - `neighbor_var`: The "secondary" variable. This could be $c_1$ from our example above. | |||
| - `boundary`: The interfacial boundary between the subdomains. Note that this must be a sideset and again must exist on the same subdomain as the primary variable. The fact that this boundary is a sideset allows access to variable gradients. | |||
|
|
|||
| An important private parameter relevant to displaced mesh calculations is | |||
There was a problem hiding this comment.
Hm - just to make sure. There's no case where we would want this to be a public param, correct?
There was a problem hiding this comment.
This parameter was only introduced to support cohesive zone and its fake neighbors. I think the day when we make fake neighbors a first class capability in libMesh (e.g. they're actually accessible via calls like neighbor_ptr and are thus no longer "fake") is the day that we can make this parameter public. As of right now the way we do cohesive zone is kind of an abuse
| @@ -0,0 +1,139 @@ | |||
| [Mesh] | |||
There was a problem hiding this comment.
You've got some mismatched hit styles here - make it consistent?
| // shouldn't we add isuo | ||
| _reinit_displaced_face = true; | ||
| else if (iuo) | ||
| _reinit_displaced_neighbor = true; |
lindsayad
force-pushed
the
displaced-face-czm-18175
branch
from
1e1b24b
to
aa60045
Compare
| block = '0' | ||
| [] | ||
|
|
||
|
|
There was a problem hiding this comment.
Ok I removed the space 😄 Can you re-approve?
Or at least we should not try to invert physical points related to interface kernels unless we actually have a displaced interface kernel in our system Closes idaholab#18175
lindsayad
force-pushed
the
displaced-face-czm-18175
branch
from
aa60045
to
62e4b53
Compare
|
This broke next: https://civet.inl.gov/event/70823/ Just look at the parallel and recover failures, rest are unrelated |
|
Ok I will look at this first thing tomorrow morning |
Fix missing reinit introduced in #18225
Or at least we should not try to invert physical points related to
interface kernels unless we actually have a displaced interface kernel
in our system
Closes #18175