-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The RC User Object and other stuff for monotonicity #18563
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindsayad
force-pushed
the
insfv-interpolator
branch
from
August 10, 2021 21:58
9958d4d
to
d5a0d2a
Compare
lindsayad
force-pushed
the
insfv-interpolator
branch
from
September 21, 2021 01:48
5f24d9a
to
455e170
Compare
lindsayad
force-pushed
the
insfv-interpolator
branch
from
September 22, 2021 19:17
f99c4a5
to
dbc770c
Compare
lindsayad
force-pushed
the
insfv-interpolator
branch
13 times, most recently
from
September 28, 2021 20:56
22319e7
to
1727aa1
Compare
lindsayad
force-pushed
the
insfv-interpolator
branch
7 times, most recently
from
October 5, 2021 21:44
99157fd
to
101139a
Compare
3 tasks
Simultaneously convert INSFVScalarFieldAdvection to transport C as opposed to rho*c.
I guess we don't test skew correction NS on CIVET otherwise I feel like we would have caught this sooner.
This reverts commit 1dc5303.
This enables coverage of a couple NS tests. NS is the module that is most sensitive to upticks in container size because we cache AD data, which is a memory cost. Other AD users should not experience any CPU or memory penalties because of this uptick
This enables backwards and forward compatibility with a libmesh update
I'm just not sure that they're necessary for stability and they are not physical. I am going to keep around the ability to interpolate and reconstruct porosity because in the three region test from Sebastian which varies porosity, putting 10 smoothing layers on the porosity allows you to have 1000 times less diffusivity in the `PINSFVMomentumFriction` kernel
Co-authored-by: Guillaume Giudicelli <guillaume.giudicelli@gmail.com>
lindsayad
force-pushed
the
insfv-interpolator
branch
from
February 11, 2022 01:51
07c24b6
to
92ba286
Compare
GiudGiud
approved these changes
Feb 11, 2022
Merged
This was referenced Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key points:
Key additions:
Moose::FV::greenGaussGradient
function which represents an abstraction away from variables and towards functors. We can now compute a gradient for any functor fieldMoose::FV::interpolateReconstruct
functionCellCenteredMapFunctor
for holding the resulting interpolated-reconstructed field and in conjunction with that, I've created aVectorComponentFunctor
which is automatically invoked when someone callsgreenGaussGradient
with a vector functor. This was done to allow easy reconstruction of vector fieldsOther items
INSFVElementalKernel
due to body force interpolations and reconstructionPINSFVMomentumAdvectionPorosityGradient
PINSFVMomentumDiffusion
To-do
computeResidual
andcomputeJacobian
as empty{}
)Maybe to-do
DefaultCoupling
and split out a utility