Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optionally allow uniform refinements when using a pre-split mesh #18576

Merged
merged 4 commits into from Aug 19, 2021
Merged

Optionally allow uniform refinements when using a pre-split mesh #18576

merged 4 commits into from Aug 19, 2021

Conversation

fdkong
Copy link
Contributor

@fdkong fdkong commented Aug 10, 2021

Closes #18575

@fdkong fdkong requested a review from rwcarlsen August 10, 2021 20:30
@moosebuild
Copy link
Contributor

moosebuild commented Aug 10, 2021 •
edited

Job Documentation on b549897 wanted to post the following:

View the site here

This comment will be updated on new commits.

@fdkong fdkong force-pushed the split_uniform_refinement branch 2 times, most recently from ec3c708 to 8401bec Compare August 11, 2021 00:05
rwcarlsen
rwcarlsen suggested changes Aug 11, 2021
View reviewed changes
Copy link
Contributor

@rwcarlsen rwcarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think maybe "skip_refine_when_use_split" defaulting to true would be a bit better naming/semantic. It's more clear what is going on. Other than that, this looks good.

@GiudGiud
Copy link
Contributor

This seems to allow mesh generators to be ran as well, not just uniform refinement?

@rwcarlsen
Copy link
Contributor

@GiudGiud - this should only affect the mesh complete action for the uniform_refine task - so nothing outside the uniform refine behavior should be changing. If I missed something, could you point to the line that you think causes mesh generators to run that normally was being skipped before?

@GiudGiud
Copy link
Contributor

ah nevermind wrong action.

@GiudGiud
Copy link
Contributor

I'm adding a similar boolean
Is this going in as a skip or as an allow?

@fdkong
Copy link
Contributor Author

fdkong commented Aug 19, 2021

@rwcarlsen It is ready for review again

@fdkong fdkong merged commit a29ecbb into idaholab:next Aug 19, 2021
@fdkong fdkong deleted the split_uniform_refinement branch August 20, 2021 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwcarlsen rwcarlsen rwcarlsen approved these changes

Assignees

@rwcarlsen rwcarlsen

Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow uniform refinements when using a pre-split mesh
4 participants
@fdkong @moosebuild @GiudGiud @rwcarlsen