Adding a RefineSidesetGenerator for refining boundaries #18914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
requested changes
Sep 28, 2021
GiudGiud
requested changes
Sep 28, 2021
|
Job Documentation on a0f3ef8 wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Generate and verify coverage on a0f3ef8 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReportsThis comment will be updated on new commits. |
||||||||||||||||||||||||||
|
Let's clean up the commit history. |
loganharbour
requested changes
Sep 29, 2021
framework/doc/content/source/meshgenerators/RefineSidesetGenerator.md
Outdated
Show resolved
Hide resolved
loganharbour
requested changes
Sep 30, 2021
socratesgorilla
force-pushed
the
refineSideset2
branch
from
3071ee1
to
6df3dff
Compare
socratesgorilla
requested review from
bwspenc,
dschwen,
lindsayad and
rwcarlsen
as code owners
socratesgorilla
removed request for
dschwen,
rwcarlsen,
bwspenc and
lindsayad
socratesgorilla
force-pushed
the
refineSideset2
branch
2 times, most recently
from
549fdb3
to
a974364
Compare
Updated generate function for RefineSidesetGenerator.C Added test files for RefineSidesetGenerator Cleanup code and add documentation for RefineSidesetGenerator Updated test files, added golds to RefineSidesetGenerator Formatting and doc edits for PR idaholab#18913 More formatting changes, and optimizing the recursive refine algorithm Applying the formatting patch for RefineSideset Changed get_boundary_info() call to work in-line rather than an explicit declaration Clang-format changes to RefineSidesetGenerator.C Added documentation files to RefineSidesetGenerator. Apply minor formatting and documentation changes from code review Update framework/src/meshgenerators/RefineSidesetGenerator.C Update framework/src/meshgenerators/RefineSidesetGenerator.C Co-Authored-By: Logan Harbour <loganhharbour@gmail.com>
socratesgorilla
force-pushed
the
refineSideset2
branch
from
a974364
to
ebf9280
Compare
GiudGiud
requested changes
Sep 30, 2021
…caused by clang-format incorrectly formatting a for loop
…oundary ids are retrieved in RefineSidesetGenerator.C
|
Job Documentation on b264c73 : invalidated by @GiudGiud I think this died |
GiudGiud
reviewed
Oct 5, 2021
GiudGiud
force-pushed
the
refineSideset2
branch
from
4b138e4
to
dda5aed
Compare
GiudGiud
previously approved these changes
Oct 5, 2021
|
Job Precheck on dda5aed wanted to post the following: Your code requires style changes. A patch was auto generated and copied here
Alternatively, with your repository up to date and in the top level of your repository:
|
Update framework/include/meshgenerators/RefineSidesetGenerator.h
GiudGiud
force-pushed
the
refineSideset2
branch
from
dda5aed
to
a0f3ef8
Compare
GiudGiud
approved these changes
Oct 5, 2021
loganharbour
approved these changes
Oct 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #18913
Adds a new mesh_generator that refines elements along one or more boundaries