Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get points for SpatialVPP from user object #18932

Merged
merged 11 commits into from Sep 28, 2021

Conversation

aprilnovak
Copy link
Contributor

This adds the capability for the SpatialUserObjectVectorPostprocessor to automatically figure out a set of points at which the user object obtains unique spatial values.

Reason

Greatly simplify VPP usage in Cardinal, where we have spatial user objects that bin according to a subchannel discretization where the user never provides a points or points_file, but instead the bin centroids are centers of triangular and 4-sided polygons in space.

Design

A good example for the design is seen for the NearestPointLayered...-type user objects. These are given a set of nearest points from the user and a layering discretization along a Cartesian axis. If the nearest points are:

1.0 2.0 3.0
1.5 2.5 3.5
1.6 2.6 3.6

and there are 2 layers in the y-direction in a domain with y coordinate spanning from 0 to 1.0, then the computed points are:

1.0 0.25 3.0 # first nearest point, at the centers of the 2 y layers
1.0 0.75 3.0

1.5 0.25 3.5 # second nearest point, at the centers of the 2 y layers
1.5 0.75 3.5

1.6 0.25 3.6 # third nearest point, at the centers of the 2 y layers
1.6 0.75 3.6

Impact

New feature, no expected changes to APIs.

Closes #18931

@moosebuild
Copy link
Contributor

moosebuild commented Sep 27, 2021

Job Documentation on feab107 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Sep 27, 2021

Job Generate and verify coverage on feab107 wanted to post the following:

Framework coverage

16ff5b #18932 feab10
Total Total +/- New
Rate 81.57% 81.58% +0.01% 95.12%
Hits 69539 69573 +34 39
Misses 15716 15712 -4 2

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

Job Precheck on 307e58d wanted to post the following:

Your code requires style changes.

A patch was auto generated and copied here
You can directly apply the patch by running, in the top level of your repository:

curl -s https://mooseframework.inl.gov/docs/PRs/18932/style.patch | git apply -v

Alternatively, with your repository up to date and in the top level of your repository:

git clang-format 835a1b59de70dea2aac6a356bbf8e8a3038662ae

@andrsd
Copy link
Contributor

andrsd commented Sep 28, 2021

Some input files are still using use_points_from_uo and that's why tests are failing. You can ./run_tests --error-unused to find them, @aprilnovak .

@aprilnovak
Copy link
Contributor Author

Thanks @andrsd! Accidentally missed those

@loganharbour loganharbour added the PR: Auto Merge Add this label to have CIVET merge on success label Sep 28, 2021
@moosebuild moosebuild merged commit 643f02f into idaholab:next Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Auto Merge Add this label to have CIVET merge on success
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow SpatialUserObjectVectorPostprocessor to get points from UO
4 participants