Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fixes for PINSFV porous jump investigation #20598

Merged
merged 1 commit into from Mar 21, 2022

Conversation

GiudGiud
Copy link
Contributor

My other PR is delayed so I just want to get those in to facilitate having a look at porous jumps in Joe's example's context

@lindsayad

@moosebuild
Copy link
Contributor

moosebuild commented Mar 21, 2022

Job Documentation on 15a82a4 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Mar 21, 2022

Job Coverage on 15a82a4 wanted to post the following:

Framework coverage

Coverage did not change

Modules coverage

Navier stokes

83ee3d #20598 15a82a
Total Total +/- New
Rate 83.65% 83.66% +0.01% 100.00%
Hits 8388 8393 +5 10
Misses 1639 1639 - 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@GiudGiud
Copy link
Contributor Author

GiudGiud commented Mar 21, 2022

second commit s not useful I need to change this
EDIT seems the functor isnt not being parsed properly

@GiudGiud GiudGiud merged commit cba2b4c into idaholab:next Mar 21, 2022
@GiudGiud GiudGiud deleted the PR_fv_fixes branch March 21, 2022 20:07
@GiudGiud GiudGiud self-assigned this Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants