Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miscellaneous docs + small improvements #20956

Merged
merged 32 commits into from
May 29, 2022
Merged

Miscellaneous docs + small improvements #20956

merged 32 commits into from
May 29, 2022

Conversation

GiudGiud
Copy link
Contributor

@GiudGiud GiudGiud commented May 5, 2022

early PR see what breaks

@moosebuild
Copy link
Contributor

moosebuild commented May 5, 2022 •
edited

Job Documentation on 27a74ac wanted to post the following:

View the site here

This comment will be updated on new commits.

@GiudGiud GiudGiud requested a review from cticenhour May 9, 2022 20:35
@GiudGiud
Copy link
Contributor Author

GiudGiud commented May 9, 2022

@grmnptr or @lindsayad on the proposed NSFV action change.
Everything else is general and open to everyone's thoughts on improving

@idaholab idaholab deleted a comment from moosebuild May 9, 2022
lindsayad
lindsayad requested changes May 9, 2022
View reviewed changes
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am fine with doing things the way you are doing it in NSFVAction; it might be more obvious if we use a semicolon delimiter and change the parameter type to be a vector of vectors. But I don't have a strong preference

framework/include/meshgenerators/SideSetLowerDElementsGenerator.h Outdated Show resolved Hide resolved
modules/navier_stokes/src/actions/NSFVAction.C Outdated Show resolved Hide resolved
modules/navier_stokes/src/actions/NSFVAction.C Outdated Show resolved Hide resolved
@GiudGiud GiudGiud force-pushed the PR_rename_misc branch 2 times, most recently from bd86608 to 5fd4e29 Compare May 11, 2022 21:51
@idaholab idaholab deleted a comment from moosebuild May 11, 2022
@idaholab idaholab deleted a comment from moosebuild May 11, 2022
@GiudGiud GiudGiud force-pushed the PR_rename_misc branch 3 times, most recently from 862303f to 1db136a Compare May 12, 2022 00:26
@idaholab idaholab deleted a comment from moosebuild May 12, 2022
@moosebuild
Copy link
Contributor

moosebuild commented May 12, 2022 •
edited

Job Coverage on 27a74ac wanted to post the following:

Framework coverage

300021 #20956 27a74a
Total Total +/- New
Rate 82.60% 82.60% -0.00% 87.85%
Hits 75501 75517 +16 94
Misses 15900 15908 +8 13

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

300021 #20956 27a74a
Total Total +/- New
Rate 85.43% 85.50% +0.07% 95.35%
Hits 9646 9644 -2 41
Misses 1645 1635 -10 2

Diff coverage report

Full coverage report

Stochastic tools

300021 #20956 27a74a
Total Total +/- New
Rate 90.01% 90.02% +0.01% 90.14%
Hits 4534 4538 +4 64
Misses 503 503 - 7

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 87.85% is less than the suggested 90.0%

This comment will be updated on new commits.

@GiudGiud
Copy link
Contributor Author

@YaqiWang is the divergenceAux in griffin used?
I m adding one to MOOSE based on the functor system which has more capability (FV, FE, functions etc) but also some limitations (no execution on initial)

@GiudGiud GiudGiud force-pushed the PR_rename_misc branch 2 times, most recently from 26156bf to 5b5fbce Compare May 13, 2022 23:07
@GiudGiud GiudGiud self-assigned this May 15, 2022
GiudGiud and others added 18 commits May 25, 2022 23:49
@GiudGiud @lindsayad
Make breakmeshbyblock generator accept subdomain name parameters, refs …
94e0a04 
…idaholab#20976

Update modules/stochastic_tools/include/vectorpostprocessors/Statistics.h

Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
@GiudGiud
Add note about using the fixed_mesh parameter in the documentation fo…
ed5df70 
…r the multi app project/NN transfers and mostly say it doesnt work with refinement, refs idaholab#20958
@GiudGiud
Make ParsedSubdomainMeshGenerator accept subdomain names and IDs, refs …
abf3eed 
…idaholab#20976
@GiudGiud
Make ParsedSubdomainGenrator accept subdomain names and IDs, refs ida…
9244adf 
…holab#20976
@GiudGiud
Link to other more simple functions for reading from CSV in the compl…
3c6dd22 
…ex PiecewiseConstantFromCSV docs
@GiudGiud
Rename multiappcommand line control to multiappSamplerControl, refs i…
e9e71eb 
…daholab#20865
@GiudGiud
Add convection correlation kernel for INSFV
bf15c72
@GiudGiud
Rename MultiAppCommandLineControl to MultiAppSamplerControl in test f…
7725692 
…iles and examples, refs idaholab#20865
@GiudGiud
Allow vector inputs for passive scalar coupled forces, refs idaholab#…
bc5dc7c 
…20961
@GiudGiud
Add documentation for loading split meshes with FileMeshGenerator refs …
b044042 
…idaholab#18635
@GiudGiud
Add test for loading split mesh with FileMeshGenerator, refs idaholab…
c7ac5f1 
…#18635
@GiudGiud @lindsayad
Fixup non unity build and lcoal AD tests
ce0af17 
Apply suggestions from code review

Co-authored-by: Alex Lindsay <alexlindsay239@gmail.com>
@GiudGiud
Rename deprecated FVScalarLagrangeMultipler in inputs
2aae071
@GiudGiud
Make check on whether to skip linear interpolation creating in VPPFun…
523bc85 
…ction more robust

closes idaholab#21007
@GiudGiud
Remove sideset_lower_D_element_generator as it duplicates with lower_…
15fd231 
…D_element_generator, refs idaholab#20865

Fix test failures
@GiudGiud
Make sure we dont hit a warning before the expected error in Property…
daf826f 
…ReadFile test, refs idaholab#19109
@GiudGiud
Fixup documentation for PINSFV, refs idaholab#16756
6646c91
@GiudGiud
Use the current number of nodes for checking the range of elements to…
dba854a 
… access, in case of refinement where it ll increase, refs idaholab#19109
@GiudGiud
Copy link
Contributor Author

Added one more commit and fudged in the update commmit into the relevant commit

@moosebuild
Copy link
Contributor

Job Controlled app tests on 27a74ac : invalidated by @GiudGiud

fix was merged

@GiudGiud
Copy link
Contributor Author

https://civet.inl.gov/job/1059922/ is still running but has gone beyond where the previous one finished so we know by now they are all green (or unrelated failure)

@GiudGiud GiudGiud merged commit 52850c9 into idaholab:next May 29, 2022
@GiudGiud GiudGiud deleted the PR_rename_misc branch May 29, 2022 01:15
@GiudGiud
Copy link
Contributor Author

Refs #17046 #20955 #20535 #20865 #16248 #18510 #20809 #20976 #20958 #20961 #18635 #21007 #19109 #16756 #19472

@GiudGiud GiudGiud mentioned this pull request Feb 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lindsayad lindsayad lindsayad approved these changes

@fdkong fdkong Awaiting requested review from fdkong

@zachmprince zachmprince Awaiting requested review from zachmprince zachmprince is a code owner

@loganharbour loganharbour Awaiting requested review from loganharbour loganharbour is a code owner

@cticenhour cticenhour Awaiting requested review from cticenhour

Assignees

@GiudGiud GiudGiud

Labels
PR: Failed but allowed PR: Ready for review/merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GiudGiud @moosebuild @lindsayad