Revert mark mortar constraint variable as active in fe_problem #21312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lab#19444) These lines of code make assessment cases leveraging mortar constraints to model gap heat transfer. It appears that problem variables (temperature) are not properly intitialized when reinitializing face materials from the mortar constraint loop. The ultimate cause of this issue is not known, but it's not straightforward to reproduce in a MOOSE regression test.
recuero
changed the title
|
Job Documentation on 755c9ed wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage on 755c9ed wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||
lindsayad
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These lines of code make assessment cases leveraging mortar constraints to model gap heat transfer fail. It appears that problem variables (temperature) are not properly initialized when reinitializing face materials (e.g. creep/thermal expansion) from the mortar constraint loop. The ultimate cause of this issue is not known to me, but it's not straightforward to reproduce in a MOOSE regression test unfortunately.
Tagging @lindsayad who has more insight into what the cause can be.
Refs #19444.