Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BoundaryElemIntegrityCheckThread Bug Fix for Boundary Integrity Check on SideUserObject Using Lower-d Variable #21567

Merged
merged 1 commit into from Jul 13, 2022

Conversation

yjung-anl
Copy link
Contributor

closes #21566

@YaqiWang
Copy link
Contributor

@lindsayad This seems a proper small/quick fix for a bug. @yjung-anl needs this for a capability in Griffin. Please review/merge this. Thanks!

@moosebuild
Copy link
Contributor

moosebuild commented Jul 12, 2022

Job Documentation on 94b3190 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Jul 12, 2022

Job Coverage on 94b3190 wanted to post the following:

Framework coverage

d655d3 #21567 94b319
Total Total +/- New
Rate 83.54% 83.55% +0.00% 100.00%
Hits 77882 77888 +6 6
Misses 15340 15339 -1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test for this to make sure we don't regress in the future?

@yjung-anl
Copy link
Contributor Author

@lindsayad
Test cases were added.

@yjung-anl yjung-anl force-pushed the boundary_integrity_check_fix branch from e41526e to 94b3190 Compare July 13, 2022 10:29
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure unrelated. Thanks for the bug fix @yjung-anl !

@lindsayad lindsayad merged commit d14a721 into idaholab:next Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BoundaryElemIntegrityCheckThread Bug for Boundary Integrity Check on SideUserObject using Lower-d Variable
4 participants