Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed allow-unused being set in run_tests for downstream apps #22840

Merged
merged 2 commits into from Dec 9, 2022
Merged

Fixed allow-unused being set in run_tests for downstream apps #22840

merged 2 commits into from Dec 9, 2022

Conversation

socratesgorilla
Copy link
Contributor

@socratesgorilla socratesgorilla commented Nov 30, 2022 •
edited

Also some minor documentation changes that made it through the cracks

Closes #22839

@moosebuild
Copy link
Contributor

moosebuild commented Dec 1, 2022 •
edited

Job Documentation on 484b42a wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Dec 1, 2022 •
edited

Job Coverage on 484b42a wanted to post the following:

Framework coverage

af38e9 #22840 484b42
Total Total +/- New
Rate 84.47% 84.47% -0.00% -
Hits 80918 80914 -4 0
Misses 14872 14876 +4 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@socratesgorilla socratesgorilla mentioned this pull request Dec 1, 2022
Closed
@moosebuild
Copy link
Contributor

Job Internal app tests on 4c3f063 : invalidated by @recuero

@GiudGiud GiudGiud self-assigned this Dec 7, 2022
@moosebuild
Copy link
Contributor

Job Internal app tests on 484b42a : invalidated by @recuero

@moosebuild
Copy link
Contributor

Job Controlled app tests on 484b42a : invalidated by @GiudGiud

SAM should have been fixed

@GiudGiud
Copy link
Contributor

GiudGiud commented Dec 8, 2022

@mangerij can you please give access to Ferret to @socratesgorilla who works at INL so they can patch it

@GiudGiud GiudGiud dismissed joshuahansel’s stale review December 9, 2022 23:42

review was addressed

@GiudGiud GiudGiud merged commit 7fadb2f into idaholab:next Dec 9, 2022
@GiudGiud
Copy link
Contributor

GiudGiud commented Dec 9, 2022

Thanks for the patch @socratesgorilla !

@loganharbour
Copy link
Member

Please fix grizzly https://civet.inl.gov/job/1262685/

@mangerij
Copy link
Contributor

@socratesgorilla

apologies, didn't see the Github notification. Access granted!

@mangerij
Copy link
Contributor

@socratesgorilla @loganharbour sorry about this late fix - holidays got the best of me but back to business and Ferret is now integrating forward with CIVET again. cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiudGiud GiudGiud GiudGiud approved these changes

@joshuahansel joshuahansel joshuahansel left review comments

Assignees

@GiudGiud GiudGiud

Labels
PR: Failed but allowed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow-unused is being set as the default for downstream apps
6 participants
@socratesgorilla @moosebuild @GiudGiud @loganharbour @mangerij @joshuahansel