Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regression test for AMR w/ high-order SCALARs #23075

Merged
merged 2 commits into from Jan 6, 2023

Conversation

roystgnr
Copy link
Contributor

@roystgnr roystgnr commented Jan 5, 2023

This resolves #12309 and #12538

The libMesh bug here got fixed years ago, but apparently the MOOSE test coverage for the fix got lost in the couch cushions until I stumbled across it while searching old issues.

This resolves idaholab#12309 and idaholab#12538

The libMesh bug here got fixed years ago, but apparently the MOOSE test
coverage for the fix got lost in the couch cushions until I stumbled
across it while searching old issues.
@moosebuild
Copy link
Contributor

moosebuild commented Jan 5, 2023

Job Documentation on d2241c9 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Jan 5, 2023

Job Coverage on d2241c9 wanted to post the following:

Framework coverage

cebfc5 #23075 d2241c
Total Total +/- New
Rate 84.53% 84.53% +0.00% -
Hits 81634 81636 +2 0
Misses 14937 14935 -2 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

test/tests/adaptivity/scalar/tests Outdated Show resolved Hide resolved
lindsayad
lindsayad previously approved these changes Jan 5, 2023
@lindsayad lindsayad dismissed their stale review January 5, 2023 23:28

need requirement change

Copy link
Member

@cticenhour cticenhour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks all!

@roystgnr roystgnr merged commit c167ac3 into idaholab:next Jan 6, 2023
@roystgnr roystgnr deleted the high_order_scalar_amr branch January 6, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash with adaptivity + high order scalar variables
4 participants