Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mesh Metadata to Existing Meshes #23136

Merged
merged 1 commit into from Jan 18, 2023
Merged

Conversation

miaoyinb
Copy link
Contributor

closes #23135

Reason

Design

Impact

@moosebuild
Copy link
Contributor

moosebuild commented Jan 12, 2023

Job Documentation on 815dbb0 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Jan 12, 2023

Job Coverage on 815dbb0 wanted to post the following:

Framework coverage

bd99c2 #23136 815dbb
Total Total +/- New
Rate 84.59% 84.61% +0.02% 96.92%
Hits 81805 81934 +129 126
Misses 14899 14900 +1 4

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

Copy link
Contributor

@GiudGiud GiudGiud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's squash the typos fix commits please then let's merge this

@GiudGiud GiudGiud merged commit 3baca54 into idaholab:next Jan 18, 2023
@GiudGiud
Copy link
Contributor

Awesome. Thanks for the contribution! And for covering so many cases from the get go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Mesh Metadata to Existing Meshes
3 participants