-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache subdomain changes #23372
Cache subdomain changes #23372
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can we add a regression test for this?
Test added. I confirmed that the new test fails with the current MOOSE in dbg mode, but passes with this PR. |
Job Documentation on fee12ae wanted to post the following: View the site here This comment will be updated on new commits. |
cbda8af
to
c283523
Compare
Job Coverage on fee12ae wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
This comment will be updated on new commits. |
c283523
to
fee12ae
Compare
The tests didn't cover displaced meshes. New test added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. This PR can fix the referenced issue.
Closes #23371