Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache subdomain changes #23372

Merged
merged 2 commits into from
Feb 9, 2023
Merged

Conversation

dschwen
Copy link
Member

@dschwen dschwen commented Feb 7, 2023

Closes #23371

hugary1995
hugary1995 previously approved these changes Feb 8, 2023
Copy link
Contributor

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can we add a regression test for this?

@dschwen
Copy link
Member Author

dschwen commented Feb 8, 2023

Test added. I confirmed that the new test fails with the current MOOSE in dbg mode, but passes with this PR.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 8, 2023

Job Documentation on fee12ae wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 8, 2023

Job Coverage on fee12ae wanted to post the following:

Framework coverage

198b8c #23372 fee12a
Total Total +/- New
Rate 84.70% 84.71% +0.01% 100.00%
Hits 82861 82878 +17 7
Misses 14967 14955 -12 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@dschwen
Copy link
Member Author

dschwen commented Feb 8, 2023

The tests didn't cover displaced meshes. New test added.

Copy link
Contributor

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. This PR can fix the referenced issue.

@bwspenc bwspenc merged commit 9a9c315 into idaholab:next Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElementSubdomainModifier should not modify SubdomainIDs during the element loop
4 participants