Miscellaneous mesh generator fixes and improvements #25086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
force-pushed
the
PR_daniel_misc
branch
2 times, most recently
from
a4b508e
to
ab061a1
Compare
Actually prevent overlap between boundaries when stitching refs idaholab#24513
refs # 22848
GiudGiud
force-pushed
the
PR_daniel_misc
branch
from
ab061a1
to
8da387e
Compare
|
Job Documentation on a52bf9d wanted to post the following: View the site here This comment will be updated on new commits. |
|
Job Coverage on a52bf9d wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
lindsayad
requested changes
Aug 3, 2023
Better tests requirements better error message Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>
GiudGiud
force-pushed
the
PR_daniel_misc
branch
from
634ddf8
to
a52bf9d
Compare
lindsayad
approved these changes
Aug 3, 2023
|
Thanks for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More usable like this
Came from @Dlevario07 's meshing work
refs #25090 #22848 #24513