See which apps will fail with the new skip-initial-residual-evaluation behavior #26222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR deprecates the parameter `compute_initial_residual_before_preset_bcs` in favor of `use_pre_initial_residual`. The user should set this parameter to true if they really want to use the pre-initial residual in the relative convergence check. The pre-initial residual is defined as the norm of the residual evaluated at the beginning of the time step before any solution-modifying object is executed. Solution-modifying objects are the objects that can potentially modify the solution vector. Currently, solution-modifying objects that are accounted for include: - preset BCs - constraints - predictors If the user does not explicitly ask to use the pre-initial residual, the pre-initial residual evaluation will be entirely skipped. Even if the user asks for that, the pre-initial residual evaluation will be skipped if there is no active solution-modifying objects. This behavior is consistent with the original discussion in the referenced issue. See NonlinearSystemBase::shouldEvaluatePreinitialResidual() for the logic behind this. And please help me double check my logic. close idaholab#10464
hugary1995
requested review from
lindsayad,
bwspenc,
jiangwen84,
joshuahansel,
dschwen,
zachmprince,
grmnptr,
GiudGiud,
loganharbour,
roystgnr,
cpgr,
cticenhour and
recuero
as code owners
|
Job Documentation on e3a8049 wanted to post the following: View the site here This comment will be updated on new commits. |
|
This pull request has been automatically marked as stale because it has not had recent activity in the last 100 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the counterpart of #23472, where
use_legacy_initial_residual_evaluation_bahavioris set to false inMooseApp.C, so that we can see which apps will fail with the new behavior.Once the tests are done, I'll tabulate the failed apps.
@loganharbour