Add functor material property shortcut output #26444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiudGiud
force-pushed
the
PR_functor_out
branch
from
ca6b2d1
to
300759e
Compare
|
Job Documentation on 4050621 wanted to post the following: View the site here This comment will be updated on new commits. |
GiudGiud
force-pushed
the
PR_functor_out
branch
2 times, most recently
from
9ca1f76
to
0a59150
Compare
GiudGiud
force-pushed
the
PR_functor_out
branch
5 times, most recently
from
ae4d05c
to
2621946
Compare
GiudGiud
force-pushed
the
PR_functor_out
branch
3 times, most recently
from
398e5d6
to
57c24b4
Compare
|
Job Coverage on 4050621 wanted to post the following: Framework coverage
Modules coverageFluid properties
Full coverage reportsReports
This comment will be updated on new commits. |
||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Patch for PGH is ready |
Fix up logic, add more comments to avoid confusion next time around
functor Suppress ignored parameters in functor mat
GiudGiud
force-pushed
the
PR_functor_out
branch
from
57c24b4
to
b7ce3b8
Compare
|
Is this NEAMS MP TA work? |
|
not really I didnt charge anyone for this |
lindsayad
requested changes
Jan 15, 2024
- shorter if loop Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>
GiudGiud
force-pushed
the
PR_functor_out
branch
from
21dcded
to
4050621
Compare
|
Job GCC min debug on 4050621 : invalidated by @GiudGiud unrelated |
|
Job Docker moose on 4050621 : invalidated by @GiudGiud unrelated |
|
Job Docker moose-dev on 4050621 : invalidated by @GiudGiud unrelated |
lindsayad
approved these changes
Jan 23, 2024
|
Job Internal app tests on 4050621 : invalidated by @GiudGiud pgh fixed? |
|
Thanks for the review! I'm glad this is in it was a longstanding small item for me |
|
it's a nice addition! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #19382
this will shave the VTB near a hundred lines :)