-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Advanced stateful material restart #26680
Conversation
fed96ce
to
797524b
Compare
Job Documentation on 209a0e3 wanted to post the following: View the site here This comment will be updated on new commits. |
I was looking for a markdown file but couldn't find one... Just to clarify this PR addresses adding/removing property but doesn't enable the usage of something like "block-restricted" restart, am I right? |
correct
it doesn't, but I could think about that.can you provide more detail? |
Yeah, one of our collaborators wanted to do checkpoint and restart, and they want to keep adding new blocks to the mesh as they restart. The common blocks between the old mesh and the new mesh are always conformal, i.e. same equation system, same material storage etc. I think in theory we can support that by asking the user to specify which blocks (from the checkpoint) to restart from. Or more generally speaking, there could be two symmetric parameters I hope I explained the usage scenario I had in mind clearly enough... Let me know if otherwise. I've told our collaborators some workarounds. But this will be a useful capability to have in the future. |
cdf67a8
to
9963cc6
Compare
Job Coverage on 209a0e3 wanted to post the following: Framework coverage
Modules coveragePorous flow
Solid mechanics
Xfem
Full coverage reportsReports
This comment will be updated on new commits. |
I'm working on fixing the |
f50aaca
to
dccd45e
Compare
This supports restarting and adding/removing stateful properties refs idaholab#25840
239acd3
to
b123ee1
Compare
@hugary1995 in regard to this conversation, there's nothing stopping us now from adding additional blocks and just initializing the stateful data for those new blocks as new data, while retaining the old ones. There's an error in place for now because it's ambiguous, but we could enable this capability by just providing a list of material objects or material parameters that would be allowed to add new (clean) information while retaining old. |
@dschwen This is ready. All of the failures but one are due to the solid mechanics rename. |
Refs failure on idaholab/moose#26680
Griffin just needs a regolding because of this commit 72b37d4. |
@dschwen please. Griffin patch is near |
Griffin patch is ready. All tests passed. When this is merged, we will just need to replace the MOOSE submodule hash. |
Co-authored-by: Daniel Schwen <daniel@schwen.de>
Job Valgrind stochastic tools on 209a0e3 : invalidated by @lindsayad |
Job OpenMPI on 209a0e3 : invalidated by @lindsayad |
This supports restarting and adding/removing stateful properties
Closes #25840