Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extending MooseVariableFV to face and qp for transient two-phase flow… #26774

Merged
merged 5 commits into from
Feb 12, 2024

Conversation

tanoret
Copy link
Contributor

@tanoret tanoret commented Feb 9, 2024

Closes #26773

@tanoret
Copy link
Contributor Author

tanoret commented Feb 9, 2024

@grmnptr @MengnanLi91 I ended up coding this since I needed it for the Euler-Euler two phase model. This should enable transient simulations with the drift flux model (please see new test). Thanks!

@moosebuild
Copy link
Contributor

moosebuild commented Feb 9, 2024

Job Documentation on 84817cc wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 9, 2024

Job Coverage on 84817cc wanted to post the following:

Framework coverage

8f32c4 #26774 84817c
Total Total +/- New
Rate 85.26% 85.25% -0.01% 55.56%
Hits 100412 100420 +8 15
Misses 17359 17370 +11 12

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

8f32c4 #26774 84817c
Total Total +/- New
Rate 84.76% 84.77% +0.01% -
Hits 14577 14579 +2 0
Misses 2621 2619 -2 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 55.56% is less than the suggested 90.0%

This comment will be updated on new commits.

Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see new dot overloads added

framework/src/variables/MooseVariableFV.C Outdated Show resolved Hide resolved
framework/src/variables/MooseVariableFV.C Outdated Show resolved Hide resolved
@lindsayad lindsayad added C: Framework C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module labels Feb 10, 2024
@lindsayad
Copy link
Member

@tanoret for some reason I can't easily submit a pull request to your branch; I can't select your fork as a base for a pull request 😦 So I've pushed c9ccea2 directly to your branch. See what you think of it

@lindsayad lindsayad dismissed their stale review February 10, 2024 07:29

submitted patch for my suggestions

@tanoret
Copy link
Contributor Author

tanoret commented Feb 11, 2024

@tanoret for some reason I can't easily submit a pull request to your branch; I can't select your fork as a base for a pull request 😦 So I've pushed c9ccea2 directly to your branch. See what you think of it

Thanks @lindsayad! Awesome work!

@moosebuild
Copy link
Contributor

Job OpenMPI on 0401576 : invalidated by @MengnanLi91

seems irrelevant test failure

@lindsayad
Copy link
Member

failure is unrelated

@lindsayad lindsayad merged commit 3acbcc1 into idaholab:next Feb 12, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework C: Modules/Navier Stokes Tickets pertaining to the navier_stokes module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Face and qp time derivative evaluation for Finite Volume Variables
4 participants