Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing cut plane in CutMeshByPlaneGenerator #26903

Merged
merged 2 commits into from Feb 27, 2024

Conversation

miaoyinb
Copy link
Contributor

@miaoyinb miaoyinb commented Feb 27, 2024

closes #26902

@miaoyinb
Copy link
Contributor Author

@GiudGiud A minor bug fix. Thanks in advance.

@lindsayad lindsayad added C: Framework C: Meshing MeshGenerator system, mesh loading labels Feb 27, 2024
@GiudGiud
Copy link
Contributor

Test failures are unrelated btw. work on moose happening

@GiudGiud
Copy link
Contributor

this one is not btw

In file included from /data/civet2/build/moose/framework/build/unity_src/meshgenerators_Unity.C:19:
/data/civet2/build/moose/framework/src/meshgenerators/CutMeshByPlaneGenerator.C:115:20: error: variable 'elem_vertices_counter_1' set but not used [-Werror,-Wunused-but-set-variable]
    unsigned short elem_vertices_counter_1(0);
                   ^

@moosebuild
Copy link
Contributor

moosebuild commented Feb 27, 2024

Job Documentation on afa2585 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild
Copy link
Contributor

moosebuild commented Feb 27, 2024

Job Coverage on afa2585 wanted to post the following:

Framework coverage

d6b47a #26903 afa258
Total Total +/- New
Rate 85.29% 85.29% +0.00% 100.00%
Hits 100795 100793 -2 4
Misses 17385 17384 -1 0

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

This comment will be updated on new commits.

@GiudGiud GiudGiud merged commit 9ec0453 into idaholab:next Feb 27, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Framework C: Meshing MeshGenerator system, mesh loading
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cut_face_id/name Assignment Bug of CutMeshByPlaneGenerator
4 participants