Add physics for fully coupled k-epsilon #27614

GiudGiud · 2024-05-13T23:43:52Z

TODO:

documentation
add energy and scalar volumetric terms
add energy wall function terms
add scalar wall function terms
add cross-parameter checking between turbulence and other physics
expand testing reasonably. There are already 14 regression tests for turbulence trying out each wall function

It might take a bit to finish this. There's a lot, and a lot of options that don't work together.
I ll get back to Components

moosebuild · 2024-05-14T16:31:26Z

Job Documentation on 54e2eb3 wanted to post the following:

View the site here

This comment will be updated on new commits.

moosebuild · 2024-07-05T20:54:25Z

Job Coverage on 2c3e6e5 wanted to post the following:

Framework coverage

	634916	#27614 2c3e6e
	Total	Total	+/-	New
Rate	85.06%	85.06%	-0.00%	0.00%
Hits	104535	104532	-3	0
Misses	18359	18362	+3	1

Diff coverage report

Full coverage report

Modules coverage

Navier stokes

	634916	#27614 2c3e6e
	Total	Total	+/-	New
Rate	84.59%	83.50%	-1.09%	33.33%
Hits	16205	16301	+96	141
Misses	2952	3221	+269	282

Diff coverage report

Full coverage report

Full coverage reports

Reports

Warnings

framework new line coverage rate 0.00% is less than the suggested 90.0%
navier_stokes new line coverage rate 33.33% is less than the suggested 90.0%

This comment will be updated on new commits.

tanoret

Some very minor comments in case they help. They are mostly oriented at not deteriorating the performance of the linear solver. Nice work!

tanoret · 2024-07-08T15:15:08Z

modules/navier_stokes/src/fvkernels/INSFVTKESourceSink.C

-        destruction += destruction_visc;
+        destruction += destruction_visc + 0 * destruction_log;
      else
-        destruction += destruction_log;
+        destruction += destruction_log + 0 * destruction_visc;


Please note that this is adding unneessary computational burden to the SIMPLE-like solvers. Please add a switch to identify if we are trying to solve these equations with a simple solve. If we are, please don't do the multiplication by 0.

tanoret · 2024-07-08T15:22:09Z

modules/navier_stokes/src/fvkernels/INSFVTKEDSourceSink.C

+    mooseAssert(distance_vec.size(), "Should have found a distance vector");
+    mooseAssert(distance_vec.size() == face_info_vec.size(),
+                "Should be as many distance vectors as face info vectors");



Why are these cehck needed at this point? It seems to be adding computational burden every time that the kernel is called

asserts are removed from opt mode. It only affects devel builds, in a very minor way. They are a good practice

tanoret · 2024-07-08T15:22:32Z

modules/navier_stokes/src/fvkernels/INSFVTKEDSourceSink.C


    for (unsigned int i = 0; i < distance_vec.size(); i++)
    {
      const auto distance = distance_vec[i];
+      mooseAssert(distance > 0, "Should be at a non-zero distance");


Is this check needed at this point? It seems to justbe adding computational burden every time that we call this kernel. Please advise

same here. It does not hurt

tanoret · 2024-07-08T15:23:16Z

modules/navier_stokes/src/fvkernels/INSFVTKEDSourceSink.C

@@ -148,7 +155,7 @@ INSFVTKEDSourceSink::computeQpResidual()
        destruction += 2.0 * TKE * wall_mut / Utility::pow<2>(distance_vec[i]) / tot_weight;
      }
      else
-        destruction += std::pow(_C_mu, 0.75) * rho * std::pow(TKE, 1.5) /
+        destruction += std::pow(_C_mu, 0.75) * rho * std::pow(std::max(ADReal(0), TKE), 1.5) /


TKE should be always positive by the conservation properties of the k epsilon mode. This capping may be unnecessary

the nonlinear solver was making it negative. It's unfortunate but it happens with Newton methods

tanoret · 2024-07-08T15:24:42Z

modules/navier_stokes/src/auxkernels/kEpsilonViscosityAux.C

@@ -24,7 +24,8 @@ kEpsilonViscosityAux::validParams()
  params.addRequiredParam<MooseFunctorName>("u", "The velocity in the x direction.");
  params.addParam<MooseFunctorName>("v", "The velocity in the y direction.");
  params.addParam<MooseFunctorName>("w", "The velocity in the z direction.");
-  params.addRequiredParam<MooseFunctorName>(NS::TKE, "Coupled turbulent kinetic energy.");
+  params.addRequiredParam<MooseFunctorName>("k", "Coupled turbulent kinetic energy.");


To keep it consistent, please only use variable names in the NS namespace

I am deprecating the old name "k" and replacing it with the new NS::TKE (= tke)

tanoret · 2024-07-08T15:25:38Z

modules/navier_stokes/src/fvbcs/INSFVMixingLengthTKEDBC.C

@@ -20,7 +20,8 @@ INSFVMixingLengthTKEDBC::validParams()
  params.addClassDescription("Adds inlet boundary condition for the turbulent kinetic energy "
                             "dissipation rate based on characteristic length.");
  params.addParam<MooseFunctorName>("C_mu", 0.09, "Coupled turbulent kinetic energy closure.");
-  params.addRequiredParam<MooseFunctorName>(NS::TKE, "The turbulent kinetic energy.");


Same here. Please try to only use variable names in the NS namespace

tanoret · 2024-07-08T15:25:59Z

modules/navier_stokes/src/fvbcs/INSFVTKEDWallFunctionBC.C

@@ -26,7 +26,8 @@ INSFVTKEDWallFunctionBC::validParams()
  params.addRequiredParam<MooseFunctorName>(NS::density, "Density");
  params.addRequiredParam<MooseFunctorName>(NS::mu, "Dynamic viscosity.");
  params.addRequiredParam<MooseFunctorName>(NS::mu_t, "The turbulent viscosity.");
-  params.addRequiredParam<MooseFunctorName>(NS::TKE, "The turbulent kinetic energy.");


Please try to only use variable names in the NS namespace

see first comment, this is using NS but NS got changed so we have to code "k" as the deprecated parameter

tanoret · 2024-07-08T15:27:12Z

modules/navier_stokes/src/fvbcs/INSFVTKEDWallFunctionBC.C

@@ -82,14 +84,16 @@ INSFVTKEDWallFunctionBC::boundaryValue(const FaceInfo & fi) const
  if (y_plus <= 5.0) // sub-laminar layer
  {
    const auto laminar_value = 2.0 * weight * TKE * mu / std::pow(dist, 2);
-    return laminar_value.value();
+    // Additional zero term to make sure new derivatives are not introduced as y_plus changes
+    return laminar_value + 0 * _mu_t(makeElemArg(&_current_elem), state);


This is adding unnecessary computational burden to the linear solver. Please add a switch between linear and nonlinear if this is needed for the nonlinear solver

those are mostly removed

tanoret · 2024-07-08T15:27:51Z

modules/navier_stokes/src/fvbcs/INSFVTKEDWallFunctionBC.C

  }
  else if (y_plus >= 30.0) // log-layer
  {
    const auto turbulent_value = weight * _C_mu(makeElemArg(&_current_elem), state) *
                                 std::pow(std::abs(TKE), 1.5) /
                                 (_mu_t(makeElemArg(&_current_elem), state) * dist);
-    return turbulent_value.value();
+    // Additional zero term to make sure new derivatives are not introduced as y_plus changes
+    return turbulent_value + 0 * mu;


Same for this one. This is adding unnecessary computational burden to the linear solver. Please add a switch between linear and nonlinear if this is needed for the nonlinear solver

- not deriving from scalar advection because two variables that dont have exactly the same equation - not doing a derived class for now, until maybe we turn Turbulence into a meta-action refs idaholab#9007

refs idaholab#9007

Add names of variables as member attributes refs idaholab#9007

refs idaholab#9007

… physics

Add support for using a functor material for mu_t, preserving derivatives refs idaholab#9007

Add deprecated 'k' parameter to k-eps objects

- dont shed mu_t derivatives - use NS::computeSpeed to survive negative init - add 0 x other branch for y_plus selections of code (y_plus can change during the nonlinear solve)

better than turbulence as it simplifies boundary-checking logic

…ore cleanly and be able to check walls between heat and flow equations for lid-driven cavities

- compare to full results as the 'short' tests do not converge the solution We still expect some minor differences between segregated and fully coupled (relaxation coeffs dependence for example)

terms for sparsity pattern preservation

Add support for C_pl coeff in tubrulence physics

…to linearized) Fixup kt aux-variable creation in turb physics

Add matching outputs to segregated inputs Try bounds on k and epsilon

…for 1) fixup

…d objects Clarify lagged/not lagged terms a bit. Limit number of functor evaluations

GiudGiud self-assigned this May 13, 2024

GiudGiud force-pushed the PR_turb_keps branch from 4e422d6 to fb05b1e Compare May 14, 2024 13:59

GiudGiud requested a review from tanoret May 14, 2024 14:11

GiudGiud force-pushed the PR_turb_keps branch from fb05b1e to 2b0eff5 Compare May 14, 2024 14:15

GiudGiud force-pushed the PR_turb_keps branch from 2b0eff5 to f38f447 Compare July 5, 2024 17:43

GiudGiud force-pushed the PR_turb_keps branch from c95a485 to 2c3e6e5 Compare July 8, 2024 15:15

tanoret reviewed Jul 8, 2024

View reviewed changes

GiudGiud force-pushed the PR_turb_keps branch 3 times, most recently from 8f806c8 to 022d722 Compare July 20, 2024 00:20

GiudGiud added 13 commits July 19, 2024 18:21

Easier error message for people who cant count

de9c62e

Add k-eps turbulence to turbulence physics:

8339c4a

- not deriving from scalar advection because two variables that dont have exactly the same equation - not doing a derived class for now, until maybe we turn Turbulence into a meta-action refs idaholab#9007

Add another log for dependent parameter checks

49ae259

Add most parameters to k-eps model

ee0e4a3

refs idaholab#9007

Add BCs for k-epsilon

a5eb9a7

Add names of variables as member attributes refs idaholab#9007

Input file typo fixes

058c5e3

Add k-eps turbulent equations kernels to physics

b044f3f

refs idaholab#9007

Add lid driven inputs with physics

3a0c5ff

refs idaholab#9007

Add a utility routine to check for floats

7c56df3

Add intialization of k-epsilon variables

d39d68b

refs idaholab#9007

Add option to use the full momentum expansion in fully coupled WCNSFV…

c3b47ba

… physics

Enable selection of names for turbulence k-eps variables

d2004e8

Add support for using a functor material for mu_t, preserving derivatives refs idaholab#9007

Adapt input files

935493b

GiudGiud force-pushed the PR_turb_keps branch 3 times, most recently from 612ff4e to 6905537 Compare July 20, 2024 00:28

GiudGiud added 2 commits July 19, 2024 18:30

Minor changes on turbulence physics

2ecb9f0

Add deprecated 'k' parameter to k-eps objects

Retrieve the coupled Physics later to avoid construction ordering issues

644dbf0

GiudGiud force-pushed the PR_turb_keps branch from 6905537 to c817c69 Compare July 20, 2024 00:31

idaholab deleted a comment from moosebuild Jul 20, 2024

GiudGiud force-pushed the PR_turb_keps branch from c817c69 to 7f35e8b Compare July 20, 2024 01:14

GiudGiud added 20 commits July 19, 2024 19:22

Add documentation for k-epsilon in turbulence physics

5a1cafe

Add input for k-eps + energy + physics

cedf48b

Fixes for nonlinear k-epsilon

5952833

- dont shed mu_t derivatives - use NS::computeSpeed to survive negative init - add 0 x other branch for y_plus selections of code (y_plus can change during the nonlinear solve)

Turbulence physics are needed by advection-wcns physics: retrieve it

9aedbdf

Add energy wall function in FluidHT physics

2017c5f

better than turbulence as it simplifies boundary-checking logic

Add momentum wall functors to be able to do lid-driven with physics m…

2a23688

…ore cleanly and be able to check walls between heat and flow equations for lid-driven cavities

Add volumetric terms for scalar and heat transfer w/ turbulent diffusion

9773da4

Add testing for Physics:

41c5ab9

- compare to full results as the 'short' tests do not converge the solution We still expect some minor differences between segregated and fully coupled (relaxation coeffs dependence for example)

Add newton solve parameters to keep track of when to add the 0-valued

d9396b2

terms for sparsity pattern preservation

Adapt to parameters which were removed by keps rework

de60887

Synch tests between physics and non-physics syntax

c5fd048

Add k_t as auxvariable

756a12e

Add support for C_pl coeff in tubrulence physics

Limit turbulent viscosity w/ NS lower bound

f59f5d1

Add previous NL solution automatically for k-epsilon (we could limit …

582c20e

…to linearized) Fixup kt aux-variable creation in turb physics

Fix source/sink terms for newton

c6e850a

Add an option to dump all the input file in the DumpObjectsProblem

b6bd8a1

Only add walls to the TKED kernels for special treatment

fa0cb0d

Adapt to new input syntax

ab997e2

Add matching outputs to segregated inputs Try bounds on k and epsilon

Add more sparsity pattern conservation terms

f03a974

Add a second wall treatment parameter for temperature

6c80186

GiudGiud force-pushed the PR_turb_keps branch from 7f35e8b to 54e2eb3 Compare July 20, 2024 01:22

GiudGiud added 2 commits July 19, 2024 23:08

Make newton tests match gold (nonlinear solver, segregated or newton …

61b1e7b

…for 1) fixup

Add more parameters to forward from input file to keps physics-create…

ece4e17

…d objects Clarify lagged/not lagged terms a bit. Limit number of functor evaluations

GiudGiud force-pushed the PR_turb_keps branch from 54e2eb3 to e19cc93 Compare July 20, 2024 05:23

Add more newton solve special cases to preserve sparsity pattern

2c60d31

GiudGiud force-pushed the PR_turb_keps branch from e19cc93 to 2c60d31 Compare July 20, 2024 14:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add physics for fully coupled k-epsilon #27614

Add physics for fully coupled k-epsilon #27614

GiudGiud commented May 13, 2024 •

edited

Loading

moosebuild commented May 14, 2024 •

edited

Loading

moosebuild commented Jul 5, 2024 •

edited

Loading

tanoret left a comment

tanoret Jul 8, 2024

tanoret Jul 8, 2024

GiudGiud Jul 8, 2024

tanoret Jul 8, 2024

GiudGiud Jul 8, 2024

tanoret Jul 8, 2024

GiudGiud Jul 8, 2024

tanoret Jul 8, 2024

GiudGiud Jul 8, 2024

tanoret Jul 8, 2024

tanoret Jul 8, 2024

GiudGiud Jul 20, 2024

tanoret Jul 8, 2024

GiudGiud Jul 20, 2024

tanoret Jul 8, 2024

Add physics for fully coupled k-epsilon #27614

Are you sure you want to change the base?

Add physics for fully coupled k-epsilon #27614

Conversation

GiudGiud commented May 13, 2024 • edited Loading

moosebuild commented May 14, 2024 • edited Loading

moosebuild commented Jul 5, 2024 • edited Loading

Framework coverage

Modules coverage

Navier stokes

Full coverage reports

Warnings

tanoret left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GiudGiud commented May 13, 2024 •

edited

Loading

moosebuild commented May 14, 2024 •

edited

Loading

moosebuild commented Jul 5, 2024 •

edited

Loading