-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no-merge capability to mesh combiner generator #27647
Conversation
Job Documentation on e224d50 wanted to post the following: View the site here This comment will be updated on new commits. |
So now it does the same thing
|
Job Coverage on e224d50 wanted to post the following: Framework coverage
Modules coverageCoverage did not change Full coverage reportsReports
Warnings
This comment will be updated on new commits. |
The combiner has never been stitching. So imo the two objects have always been duplicating features, one with the added capability for positions (combiner) and the other one with the added check on sideset names/ids (collection). Except now there is code to prevent a merge which the MeshCollectionGenerator does not have. The mesh collection generator will still merge sidesets/blocks with the same ids if they are either unnamed or with the same name. |
Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>
Thanks for the review! |
closes #27646
This could be stuff we push upstream to libmesh tbh. It's mostly there for blocks already.