Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-merge capability to mesh combiner generator #27647

Merged
merged 4 commits into from
May 29, 2024

Conversation

GiudGiud
Copy link
Contributor

closes #27646

This could be stuff we push upstream to libmesh tbh. It's mostly there for blocks already.

@GiudGiud GiudGiud self-assigned this May 16, 2024
@GiudGiud GiudGiud marked this pull request as ready for review May 16, 2024 14:26
@moosebuild
Copy link
Contributor

moosebuild commented May 16, 2024

Job Documentation on e224d50 wanted to post the following:

View the site here

This comment will be updated on new commits.

@GiudGiud GiudGiud marked this pull request as draft May 20, 2024 01:27
@GiudGiud GiudGiud marked this pull request as ready for review May 24, 2024 12:24
@dschwen
Copy link
Member

dschwen commented May 24, 2024

So now it does the same thing MeshCollectionGenerator does?

params.addClassDescription("Collects multiple meshes into a single (unconnected) mesh.");

@moosebuild
Copy link
Contributor

moosebuild commented May 24, 2024

Job Coverage on e224d50 wanted to post the following:

Framework coverage

4409da #27647 e224d5
Total Total +/- New
Rate 85.15% 85.14% -0.01% 75.71%
Hits 103914 103955 +41 53
Misses 18123 18139 +16 17

Diff coverage report

Full coverage report

Modules coverage

Coverage did not change

Full coverage reports

Reports

Warnings

  • framework new line coverage rate 75.71% is less than the suggested 90.0%

This comment will be updated on new commits.

@GiudGiud
Copy link
Contributor Author

GiudGiud commented May 24, 2024

The combiner has never been stitching. So imo the two objects have always been duplicating features, one with the added capability for positions (combiner) and the other one with the added check on sideset names/ids (collection).
The check on sideset names/ids would have been great on the combiner too

Except now there is code to prevent a merge which the MeshCollectionGenerator does not have. The mesh collection generator will still merge sidesets/blocks with the same ids if they are either unnamed or with the same name.

framework/src/meshgenerators/CombinerGenerator.C Outdated Show resolved Hide resolved
framework/src/meshgenerators/CombinerGenerator.C Outdated Show resolved Hide resolved
framework/src/meshgenerators/CombinerGenerator.C Outdated Show resolved Hide resolved
Co-authored-by: Alex Lindsay <alexander.lindsay@inl.gov>
@GiudGiud GiudGiud merged commit 9eafad3 into idaholab:next May 29, 2024
47 of 49 checks passed
@GiudGiud GiudGiud deleted the PR_fix_combiner branch May 29, 2024 02:06
@GiudGiud
Copy link
Contributor Author

Thanks for the review!
This will help interns with mesh generation I m fairly confident

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combiner generator should not always merge sidesets and boundaries
4 participants