-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changes to libtorch installation instructions. #27689
base: next
Are you sure you want to change the base?
Conversation
Do you guys think we can create a quick CIVET recipe for this? Just to check if we can build moose like this. (It works locally) |
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
22bcfe4
to
e8990bb
Compare
Also, @hugary1995 , do you guys have anything to add here? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have major comments.
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
Oh maybe also mention the pytorch compatibility matrix: https://github.com/pytorch/pytorch/blob/main/RELEASE.md#release-compatibility-matrix |
Great, thanks @hugary1995 , will address these as soon as possible. |
Job Documentation on 2e36ba7 wanted to post the following: View the site here This comment will be updated on new commits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some heading changes to address the truncation of the navigation table.
And a brief check on using minimum_python
instead of default_python
.
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
Easily enough, yes! |
99658a9
to
2e36ba7
Compare
@hugary1995 , is this good enough for now? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one nit picky comment. Overall this looks great!
modules/doc/content/getting_started/installation/install_libtorch.md
Outdated
Show resolved
Hide resolved
I also just asked @reverendbedford about his opinion in case I missed anything. He made a good point about the fact that these new instructions kinda tell users not to use gpu libtorch on linux systems. However that's not true, even though the current conda pytorch package isn't compatible with moose-dev, there is still the option of compiling all moose dependencies, e.g. petsc, libmesh, etc, from scratch. |
And of course I'll let you guys decide whether to declare this route as "officially supported". But I think it is worth pointing out the option regardless. |
Sounds good, I'll extend this a little. We'll have a PR hopefully soon which will remove these limitations from the linux/conda combination. |
2e36ba7
to
5bf1a7c
Compare
57ce9ad
to
8f49830
Compare
Closes #27688