Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changes to libtorch installation instructions. #27689

Open
wants to merge 5 commits into
base: next
Choose a base branch
from

Conversation

grmnptr
Copy link
Contributor

@grmnptr grmnptr commented May 22, 2024

Closes #27688

@grmnptr
Copy link
Contributor Author

grmnptr commented May 22, 2024

Do you guys think we can create a quick CIVET recipe for this? Just to check if we can build moose like this. (It works locally)

@grmnptr
Copy link
Contributor Author

grmnptr commented May 22, 2024

Also, @hugary1995 , do you guys have anything to add here?

Copy link
Contributor

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have major comments.

@hugary1995
Copy link
Contributor

Oh maybe also mention the pytorch compatibility matrix: https://github.com/pytorch/pytorch/blob/main/RELEASE.md#release-compatibility-matrix

@grmnptr
Copy link
Contributor Author

grmnptr commented May 22, 2024

Great, thanks @hugary1995 , will address these as soon as possible.

@moosebuild
Copy link
Contributor

moosebuild commented May 22, 2024

Job Documentation on 2e36ba7 wanted to post the following:

View the site here

This comment will be updated on new commits.

Copy link
Member

@milljm milljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some heading changes to address the truncation of the navigation table.

And a brief check on using minimum_python instead of default_python.

@milljm
Copy link
Member

milljm commented May 23, 2024

Do you guys think we can create a quick CIVET recipe for this? Just to check if we can build moose like this. (It works locally)

Easily enough, yes!

@grmnptr grmnptr self-assigned this May 24, 2024
@grmnptr
Copy link
Contributor Author

grmnptr commented May 29, 2024

@hugary1995 , is this good enough for now?

Copy link
Member

@milljm milljm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Copy link
Contributor

@hugary1995 hugary1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit picky comment. Overall this looks great!

@hugary1995
Copy link
Contributor

I also just asked @reverendbedford about his opinion in case I missed anything. He made a good point about the fact that these new instructions kinda tell users not to use gpu libtorch on linux systems. However that's not true, even though the current conda pytorch package isn't compatible with moose-dev, there is still the option of compiling all moose dependencies, e.g. petsc, libmesh, etc, from scratch.

@hugary1995
Copy link
Contributor

However that's not true, even though the current conda pytorch package isn't compatible with moose-dev, there is still the option of compiling all moose dependencies, e.g. petsc, libmesh, etc, from scratch.

And of course I'll let you guys decide whether to declare this route as "officially supported". But I think it is worth pointing out the option regardless.

@grmnptr
Copy link
Contributor Author

grmnptr commented May 29, 2024

Sounds good, I'll extend this a little. We'll have a PR hopefully soon which will remove these limitations from the linux/conda combination.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add alternative setup instructions for libtorch for macs.
5 participants