-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TimedSubdomainModifier fails for multiple idential times (closes #27942) #27943
TimedSubdomainModifier fails for multiple idential times (closes #27942) #27943
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you envision that someone will ever have a lot of times? Because right now we do a linear search over the _times_and_indices
container in order to figure out what modifications to apply. A binary search would be a lot better
For other (non-Moose) FE models I have several 10s to a little more than 100 transitions (while per time the elements of several subdomains may change - the reason for this PR). So a more efficient search strategy than a linear search might be beneficial. I'm not sure on the binary search due to the fact that several items in _times_and_indices might have the same time value. |
Job Documentation on 6cdac73 wanted to post the following: View the site here This comment will be updated on new commits. |
5ad0001
to
6cdac73
Compare
Job Coverage on 6cdac73 wanted to post the following: Framework coverage
Modules coverageFluid properties
Full coverage reportsReports
This comment will be updated on new commits. |
closes #27942 "TimedSubdomainModifier fails for multiple idential times"
To solve this issue I had to switch to
std::vector<Real>
for the variable_times
(not using a set anymore).Please note, I also changed one of the tests to check for this special case (including a re-gold).