Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimedSubdomainModifier fails for multiple idential times (closes #27942) #27943

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

grunerjmeier
Copy link
Contributor

@grunerjmeier grunerjmeier commented Jun 19, 2024

closes #27942 "TimedSubdomainModifier fails for multiple idential times"

To solve this issue I had to switch to std::vector<Real> for the variable _times (not using a set anymore).
Please note, I also changed one of the tests to check for this special case (including a re-gold).

@grunerjmeier grunerjmeier changed the title closes #27942 TimedSubdomainModifier fails for multiple idential times (closes #27942) Jun 19, 2024
grunerjmeier added a commit to grunerjmeier/moose that referenced this pull request Jun 19, 2024
Copy link
Member

@lindsayad lindsayad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you envision that someone will ever have a lot of times? Because right now we do a linear search over the _times_and_indices container in order to figure out what modifications to apply. A binary search would be a lot better

@grunerjmeier
Copy link
Contributor Author

Do you envision that someone will ever have a lot of times? Because right now we do a linear search over the _times_and_indices container in order to figure out what modifications to apply. A binary search would be a lot better

For other (non-Moose) FE models I have several 10s to a little more than 100 transitions (while per time the elements of several subdomains may change - the reason for this PR). So a more efficient search strategy than a linear search might be beneficial. I'm not sure on the binary search due to the fact that several items in _times_and_indices might have the same time value.

@moosebuild
Copy link
Contributor

moosebuild commented Jun 19, 2024

Job Documentation on 6cdac73 wanted to post the following:

View the site here

This comment will be updated on new commits.

@lindsayad lindsayad self-assigned this Jun 19, 2024
@moosebuild
Copy link
Contributor

Job Coverage on 6cdac73 wanted to post the following:

Framework coverage

67db2d #27943 6cdac7
Total Total +/- New
Rate 85.06% 85.06% -0.00% 100.00%
Hits 104409 104402 -7 22
Misses 18336 18336 - 0

Diff coverage report

Full coverage report

Modules coverage

Fluid properties

67db2d #27943 6cdac7
Total Total +/- New
Rate 85.47% 85.48% +0.01% -
Hits 7265 7266 +1 0
Misses 1235 1234 -1 0

Diff coverage report

Full coverage report

Full coverage reports

Reports

This comment will be updated on new commits.

@lindsayad lindsayad merged commit 705cbc2 into idaholab:next Jun 19, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimedSubdomainModifier fails for multiple idential times
3 participants