change: 修改任务下发runner选择策略为轮循 #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxinging
suggested changes
Nov 23, 2022
portal/services/env.go
Outdated
| @@ -308,6 +310,11 @@ func matchVar(v forms.SampleVariables, value models.Variable) bool { | |||
| } | |||
|
|
|||
| func GetRunnerByTags(tags []string) (string, e.Error) { | |||
| tags_str := strings.Join(tags, ",") | |||
There was a problem hiding this comment.
tags 要不要排个序再组装成 tags_str，确保 tags 的传入顺序不影响 tags_str 的值
| } else { | ||
| runnerTagsIndex.Store(tags_str, 0) | ||
| } | ||
| return validRunners[rid].ID, nil |
There was a problem hiding this comment.
这里要保证 rid 不越界，有可能 runner 数量会减少
jxinging
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.