Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement std::error::Error for easier error handling #35

Merged
merged 1 commit into from
Jan 14, 2024

Conversation

bronsonp
Copy link
Contributor

Currently the thread_priority::Error type does not implement Rust's standard error trait, std::error::Error. This means that user code cannot use the ? operator in certain contexts. Examples include when using the anyhow error handling library or as part of a function that is generic over the type of error that may be returned (Box<dyn std::error::Error>). Some Rust libraries and developers may expect that types representing errors will implement std::error::Error.

This PR adds the trait implementation so that thread_priority::Error integrates more readily with the rest of the Rust ecosystem.

As a demonstration, I also refactored the should_be_possible_to_reset_the_same_priority() unit test to work with the ? operator. The code in the new unit test was a compile error until std::error::Error was implemented.

@iddm
Copy link
Owner

iddm commented Jan 14, 2024

Hi! Thank you for your contribution! Looks fine to me.

@iddm iddm merged commit 1a745c5 into iddm:master Jan 14, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants