tempsense: fix LVS, pdn.cfg -> pdn.tcl, move custom header placement to its own file #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved the customPlace_east proc (idea-fasoc#77) to a separate file for better organization (scripts/openfasoc/custom_place.tcl). Also fixes the bug where this proc would put the cells in their respective rows, sequentially, but not flip them in subsequent rows (need to be flipped because VDD and GND flip from one row to the next). Finally, also changes the status of placed cells to FIRM to ensure they won't move when detailed_placement is called.
…file Changes the pdngen configuration to the new pdn.tcl file (and their C++ code). Removed pdn.cfg, now deprecated in the tempsense. To properly route the header cells, which are connected to multiple voltage domains, an extra script create_rVIN.tcl was added to pre global route. Also moves the custom header placement added in PR idea-fasoc#77 to a separate file in scripts/openfasoc/customPlace.tcl to reduce the changes from the original OpenROAD-flow-scripts fork. Closes idea-fasoc#81
Related: idea-fasoc#97 (addresses it for the tempsense)
luccareinehr
changed the title
luccareinehr
changed the title
Allows the user to choose if the cells should be placed exactly in the rows defined, or if they can be moved slightly during detailed placement, to avoid overlapping other fixed cells (for ex., taps). Using isfixed as "no", this procedure places the cells in a region around the east of the design, while "yes" puts them exactly at the start of the Nth row (as given) subsequently.
luccareinehr
requested review from
msaligane and
saicharan0112
and removed request for
saicharan0112
…hr/OpenFASOC into customplace-tempsense
saicharan0112
approved these changes
Oct 10, 2022
There was a problem hiding this comment.
LGTM @luccareinehr. I tested this with the latest version of openroad and other tools. Its working. I also reverted back the CI to continue testing the flow with the latest versions. Though it won't update the README and dump the version numbers in the file, it will be helpful for us in keeping up with the latest releases of these tools. I also did the precommit check so you don't have to do anymore.
docs/source/developers-guide.rst
Outdated
| Once your contribution is ready, run pre-commit to pass the CI test for pull requests: | ||
|
|
||
| .. code-block:: bash | ||
|
|
There was a problem hiding this comment.
Also add installation steps for precommit?
msaligane
approved these changes
Oct 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes tempsense: lvs stopped working after openroad pull #2289 #109
Closes Update temp-sense-gen pdn.cfg to new pdngen format (pdn.tcl) #81
Moves the custom placement procedure from HEADER cells are placed in an organized fashion #77 to a separate script, and automatically rotates the placed cells according to their row direction (to align correctly with VDD / GND)
Adds an option in
customPlace_eastto allow the custom placed instances to move slightly during detailed placement, to avoid overlaps with other fixed cells (tap cells for example)Also addresses git ignore generated verilog files #97 for the temp-sense-gen (for other generators, the issue might still be valid)