Set up tests #9
Merged
Set up tests #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes idea2app#1. Also add failing tests for other issues, and set up a PR workflow. Pin `jsdom@20.x` (`SubmitEvent.submitter` was added[^1] in `21.1.0`). To test all submitter permutations, we do need a fix[^2] from `21.0.0`. Unfortunately that version is not compatible with `jest@29`, so we apply the fix using `patch-package`. [^1]: jsdom/jsdom#3481 [^2]: jsdom/jsdom#3480
TechQuery
requested changes
Apr 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1. Also add failing tests for #5, #6, #7, #8, and set up a PR workflow.
Pin
jsdom@20.x(SubmitEvent.submitterwas added1 in21.1.0). To test all submitter permutations, we do need a fix2 from21.0.0. Unfortunately that version is not compatible withjest@29, so we apply the fix usingpatch-package.Footnotes
https://github.com/jsdom/jsdom/pull/3481 ↩
https://github.com/jsdom/jsdom/pull/3480 ↩